Changes between Version 1 and Version 2 of Ticket #9132, comment 20


Ignore:
Timestamp:
Aug 23, 2021, 9:17:24 PM (5 years ago)
Author:
jeeb

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #9132, comment 20

    v1 v2  
    2828
    2929I actually noticed this the other day when reviewing an SVT-AV1 patch that touched other metadata values, but not chroma location.
     30
     31'''edit''':
     32
     33I take my comment back, apparently I had completely forgotten I had also taken care of this field when adding the passing of information in ffmpeg.c
     34
     35{{{
     36        if (frame) {
     37            enc_ctx->color_range            = frame->color_range;
     38            enc_ctx->color_primaries        = frame->color_primaries;
     39            enc_ctx->color_trc              = frame->color_trc;
     40            enc_ctx->colorspace             = frame->colorspace;
     41            enc_ctx->chroma_sample_location = frame->chroma_location;
     42        }
     43}}}
     44so heh, sometimes  you forget you did the right thing :P
     45
     46Thus it's just the end points (encoders etc) which then proceed to not do anything with it :) .
     47
     48But at this point, this is completely off-topic discussion for this issue. Which now has a fix on the mailing list waiting for review.