Changes between Version 1 and Version 2 of Ticket #9132, comment 17


Ignore:
Timestamp:
Jul 24, 2021, 6:45:42 PM (5 years ago)
Author:
jeeb

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #9132, comment 17

    v1 v2  
    55After all, the problem right now is just that when a conversion is done (RGB is converted to YCbCr), the given output AVFrame field is not reset accordingly. You can see an example of that in the `avfilter/vf_scale: reset color properties if a conversion was done` commit in my branch.
    66
     7'''edit''':
     8What I mean is that by adding RGB to libx264 you will of course get RGB by default instead of 4:4:4 YCbCr as the default pixel format, and thus the bug will not be visible. But not being visible is different from the issue actually being fixed.
     9
     10As soon as you try to encode any non-RGB from such "RGB flagged with that colorspace value", you will mistakenly get that value still in the converted output AVFrame as vf_scale or swscale does not currently clear it. Be it YCbCr 4:2:0, 4:2:2 or 4:4:4, for example.