Changes between Initial Version and Version 1 of Ticket #9127, comment 4


Ignore:
Timestamp:
Feb 28, 2021, 6:45:22 PM (5 years ago)
Author:
Andriy Gelman

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #9127, comment 4

    initial v1  
    11The problem is that sha-256 overwrites the md5 option.. and doesn't look that we support sha-256 in authentication part.
    22
    3 Could you try this patch to check that the analysis is correct?
    4 
    5 diff --git a/libavformat/httpauth.c b/libavformat/httpauth.c
    6 index 4f79c78edc..ef82c01d36 100644
    7 --- a/libavformat/httpauth.c
    8 +++ b/libavformat/httpauth.c
    9 @@ -101,6 +101,10 @@ void ff_http_auth_handle_header(HTTPAuthState *state, const char *key,
    10                                 state);
    11          } else if (av_stristart(value, "Digest ", &p) &&
    12                     state->auth_type <= HTTP_AUTH_DIGEST) {
    13 +
    14 +            if (!strcmp(state->digest_params.algorithm, "MD5"))
    15 +                return;
    16 +
    17              state->auth_type = HTTP_AUTH_DIGEST;
    18              memset(&state->digest_params, 0, sizeof(DigestParams));
    19              state->realm[0] = 0;
     3Could you try this [http://trac.ffmpeg.org/attachment/ticket/9127/test.patch patch] to check that the analysis is correct?