Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#9116 closed defect (fixed)

ffmpeg-4.3.2/libavformat/jacosubdec.c:152: missing break ?

Reported by: dcb Owned by:
Priority: normal Component: avformat
Version: 4.3.2 Keywords: jacosub
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no


Source code is

switch (n) {
case 4: ret = sign * (((int64_t)a*3600 + b*60 + c) * timeres + d);
case 3: ret = sign * (( (int64_t)a*60 + b) * timeres + c);
case 2: ret = sign * (( (int64_t)a) * timeres + b);

Change History (4)

comment:1 by Balling, 3 years ago

Resolution: invalid
Status: newclosed

This was fixed in 11ea0ed20e11dd1b19af6e23eceabce7ec76f70d in October. Really?

comment:2 by dcb, 3 years ago

I see the problem. Yes the bug may have been fixed in master in October,
but latest release 4.3.2, dated 2021-02-20, was cut from master 2020-06-08.

I think a delay of some eight months between cut and release might be the real issue.
Either that or be prepared to backport patches.

comment:3 by Balling, 3 years ago

Master is the release. Every commit in the master is a new release, okay? That is how ffmpeg works, it is always stable.

comment:4 by Carl Eugen Hoyos, 3 years ago

Component: undeterminedavformat
Keywords: jacosub added
Resolution: invalidfixed
Version: unspecified4.3.2
Note: See TracTickets for help on using tickets.