AMF Encoders are broken in ffmpeg 4.3.1 and newer release

[munishjindal]

AMF encoders are not accepting DXVA2_VLD or D3D11 surface as input. I throws error:

[h264_amf @ 0000020dd0af2e00] Format dxva2_vld is not supported

It was working in earlier ffmpeg 4.2 versions. Kindly resolve it.

The following command works fine on ffmpeg version 4.2.0

ffmpeg.exe -y -hwaccel dxva2 -hwaccel_output_format dxva2_vld -extra_hw_frames 16 -i input.mp4 -c:a aac -b:a 192k -ac 2 -ar 44100 -c:v hevc_amf -profile:v main -level 51 -usage 0 -quality 1 -b:V 4000k output.mp4

But with ffmpeg 4.3.1 it throws following error:
[h264_amf @ 0000020dd0af2e00] Format dxva2_vld is not supported

[Carl Eugen Hoyos]

Please test current FFmpeg git head and provide the command line you tested together with the complete, uncut console output to make this a valid ticket.

Which commit introduced the regression?

[munishjindal]

D:\ffmpeg-N-99756\bin>ffmpeg.exe -y -hwaccel dxva2 -hwaccel_output_format dxva2_vld -extra_hw_frames 16 -i h264_8b_avatar_720p60.mkv -c:a aac -b:a 192k -ac 2 -ar 44100 -c:v hevc_amf -profile:v main -level 51 -usage 0 -quality 1 -b:V 4000k output.mp4
ffmpeg version N-99756-g8b1bb4f38e Copyright (c) 2000-2020 the FFmpeg developers

built with gcc 9.3-win32 (GCC) 20200320
configuration: --prefix=/ffbuild/prefix --pkg-config-flags=--static --pkg-config=pkg-config --cross-prefix=x86_64-w64-mingw32- --arch=x86_64 --target-os=mingw32 --enable-gpl --enable-version3 --disable-debug --enable-shared --disable-static --disable-debug --enable-iconv --enable-zlib --enable-libxml2 --enable-libfreetype --enable-libfribidi --enable-gmp --enable-lzma --enable-fontconfig --enable-opencl --enable-libvmaf --disable-vulkan --enable-libvorbis --enable-amf --enable-libaom --enable-avisynth --enable-libdav1d --enable-libdavs2 --enable-ffnvcodec --enable-cuda-llvm --disable-libglslang --enable-libass --enable-libbluray --enable-libmp3lame --enable-libopus --enable-libtheora --enable-libvpx --enable-libwebp --enable-libmfx --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-librav1e --enable-schannel --enable-sdl2 --enable-libsoxr --enable-libsrt --enable-libsvtav1 --enable-libtwolame --enable-libuavs3d --enable-libvidstab --enable-libx264 --enable-libx265 --enable-libxavs2 --enable-libxvid --enable-libzimg --extra-cflags=-DLIBTWOLAME_STATIC --extra-cxxflags= --extra-ldflags=-pthread --extra-libs=-lgomp
libavutil 56. 60.100 / 56. 60.100
libavcodec 58.112.100 / 58.112.100
libavformat 58. 63.100 / 58. 63.100
libavdevice 58. 11.102 / 58. 11.102
libavfilter 7. 88.100 / 7. 88.100
libswscale 5. 8.100 / 5. 8.100
libswresample 3. 8.100 / 3. 8.100
libpostproc 55. 8.100 / 55. 8.100

Input #0, matroska,webm, from 'h264_8b_avatar_720p60.mkv':

Metadata:

encoder : libebml v0.8.0 + libmatroska v0.9.0
creation_time : 2010-06-12T06:31:05.000000Z

Duration: 00:01:05.70, start: 0.000000, bitrate: 14828 kb/s

Stream #0:0: Video: h264 (High), yuv420p(progressive), 1280x720 [SAR 1:1 DAR 16:9], 59.94 fps, 59.94 tbr, 1k tbn, 119.88 tbc (default)
Stream #0:1: Audio: ac3, 48000 Hz, 5.1(side), fltp, 448 kb/s (default)

Stream mapping:

Stream #0:0 -> #0:0 (h264 (native) -> hevc (hevc_amf))
Stream #0:1 -> #0:1 (ac3 (native) -> aac (native))

Press [q] to stop, ? for help
[hevc_amf @ 0000020aff2298c0] Format dxva2_vld is not supported
Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height
[aac @ 0000020afefa13c0] Qavg: 59385.605
[aac @ 0000020afefa13c0] 2 frames left in the queue on closing
Conversion failed!

[nyanmisaka]

This patch should fix this issue.
​https://patchwork.ffmpeg.org/project/ffmpeg/patch/20201015001625.32832-1-ovchinnikov.dmitrii@gmail.com/

[Marton Balint]

Fixed in 2fb764e1f3932ddb5a2a071d238a4db83e6d5a1b.