Opened 4 years ago
Last modified 4 years ago
#8765 new enhancement
advice for merging upstream: tvheadend vaapi fix
| Reported by: | th0ma7 | Owned by: | |
|---|---|---|---|
| Priority: | normal | Component: | avcodec |
| Version: | git-master | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Reproduced by developer: | no | |
| Analyzed by developer: | no |
Description
Hi,
Over the past year I've taken over the role of maintaining the ffmpeg package for SynoCommunity. From the repository history there where 2x existing patches, relatively similar, for which the name relates to fixes for tvheadend under x265 & vaapi:
- https://github.com/SynoCommunity/spksrc/blob/master/cross/ffmpeg/patches/003-tvheadend-ffmpeg.libx265.patch
- https://github.com/SynoCommunity/spksrc/blob/master/cross/ffmpeg/patches/004-tvheadend-ffmpeg.vaapi_encode.patch
With the upgrade from 4.2.3 to 4.3.0 I noticed that the libx265 patch got merged upstream in a somewhat similar form to the patch I was keeping around from the previous package maintainer, which is a really awesome news.
This makes me wonder whether the changes to libavcodec/libx265.c wouldn't be appropriate to be merged upstream as well for libavcodec/vaapi_encode.c based on the second patch link above on some shaper form?
Bare with me, I'm not a C coder, although, as the patch doesn't apply anymore against version 4.3, I thought it might be a good time to seek for advice, hopefully leading to getting "this" fix merged upstream.
Thnx really much in advance.
To be more precise, the patch from spksrc for libx265.c:
https://github.com/SynoCommunity/spksrc/blob/master/cross/ffmpeg/patches/003-tvheadend-ffmpeg.libx265.patch
Got somehow upstreamed through this commit:
https://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=3670a10c2d69dfb125ad1fe53fe8eddd9a687166
And question is, are similar changes applicable to vaapi_encode.c as well?