Opened 4 years ago

Closed 17 months ago

#8661 closed defect (fixed)

HEVC missing chroma location

Reported by: Sesse Owned by:
Priority: normal Component: avcodec
Version: git-master Keywords: hevc
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Hi,

When you're decoding HEVC video, you end up with unspecified chroma_sample_location. HEVC is left like H.264, so please add

      avctx->chroma_sample_location = AVCHROMA_LOC_LEFT;

in hevc_decode_init().

Change History (4)

comment:1 by Carl Eugen Hoyos, 4 years ago

Keywords: hevc added

Please send your patch - made with git format-patch - to the FFmpeg development mailing list.

comment:2 by Balling, 3 years ago

That is done here, in else: 8ee6557c2e93166a03ef8588a09674e4a083d43b

Also, I suppose it may be a bad idea to assume left for BT.2100. That is dolby vision profile 5 that uses left, but others use top-left, including DV in Blu-ray.

comment:3 by Balling, 2 years ago

I just find out that it always selects left even for top left as can be checked by

ffmpeg.exe -i cosmos.mkv -vf 'scale=in_h_chr_pos=0:in_v_chr_pos=128' -pix_fmt rgb24 qnfvarejwnfe3.rgb for left
ffmpeg.exe -i cosmos.mkv -vf 'scale=in_h_chr_pos=0:in_v_chr_pos=0' -pix_fmt rgb24 qnfvarejwnfe3.rgb for top-left

Last edited 2 years ago by Balling (previous) (diff)

comment:4 by Carl Eugen Hoyos, 17 months ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.