Opened 3 years ago

Closed 3 years ago

#8355 closed defect (fixed)

FFmpeg build broken with QSV

Reported by: eero-t Owned by:
Priority: normal Component: avcodec
Version: git-master Keywords:
Cc: zhongli_dev@126.com Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Commit 33583803e107 added dependency to qsvenc_vp9.o, but there's no corresponding source file added:

$ git pull
Already up to date.
$ find -name 'qsvenc*'
./libavcodec/qsvenc.c
./libavcodec/qsvenc_hevc.c
./libavcodec/qsvenc.h
./libavcodec/qsvenc_jpeg.c
./libavcodec/qsvenc_mpeg2.c
./libavcodec/qsvenc_h264.c
$ git show --format=fuller 33583803e107
commit 33583803e107b6d532def0f9d949364b01b6ad5a
Author:     Zhong Li <zhongli_dev@126.com>
AuthorDate: Sat Oct 26 22:18:31 2019 +0800
Commit:     Zhong Li <zhongli_dev@126.com>
CommitDate: Sun Nov 3 16:45:35 2019 +0800

    lavc/qsvenc: enable vp9 encoder
...
diff --git a/libavcodec/Makefile b/libavcodec/Makefile
index 34c3a22116..2b6fbbca2a 100644
--- a/libavcodec/Makefile
+++ b/libavcodec/Makefile
@@ -685,6 +685,7 @@ OBJS-$(CONFIG_VP9_CUVID_DECODER)       += cuviddec.o
 OBJS-$(CONFIG_VP9_MEDIACODEC_DECODER)  += mediacodecdec.o
 OBJS-$(CONFIG_VP9_RKMPP_DECODER)       += rkmppdec.o
 OBJS-$(CONFIG_VP9_VAAPI_ENCODER)       += vaapi_encode_vp9.o
+OBJS-$(CONFIG_VP9_QSV_ENCODER)         += qsvenc_vp9.o
 OBJS-$(CONFIG_VPLAYER_DECODER)         += textdec.o ass.o
 OBJS-$(CONFIG_VP9_V4L2M2M_DECODER)     += v4l2_m2m_dec.o
 OBJS-$(CONFIG_VQA_DECODER)             += vqavideo.o
...
$ configure --enable-libmfx --enable-vaapi ...
...
$ make
....
ar: libavcodec/qsvenc_vp9.o: No such file or directory
ffmpeg/ffbuild/library.mak:21: recipe for target 'libavcodec/libavcodec.a' failed
make: *** [libavcodec/libavcodec.a] Error 1

Change History (2)

comment:1 by mkver, 3 years ago

Patch is already here on the mailing list.

comment:2 by Zhong,Li, 3 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.