Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#8046 closed defect (invalid)

Free a non-heap memory

Reported by: wurongxin Owned by:
Priority: minor Component: avcodec
Version: git-master Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Summary of the bug:
How to reproduce:

% ffmpeg -i input ... output
ffmpeg version
built on ...

Patches should be submitted to the ffmpeg-devel mailing list and not this bug tracker.

In the source exr.c, at Line 1615, the function av_dict_set may free the variable "key" which is a non-heap memory object. For more details, please read the code snippet in the attachment.

Attachments (1)

Screenshot 2019-07-28 at 10.09.55 PM.png (184.8 KB ) - added by wurongxin 2 years ago.
Code snippet of the bug

Download all attachments as: .zip

Change History (5)

by wurongxin, 2 years ago

Code snippet of the bug

comment:1 by wurongxin, 2 years ago

Priority: normalcritical

comment:2 by wurongxin, 2 years ago

Version: unspecifiedgit-master

comment:3 by Elon Musk, 2 years ago

Priority: criticalminor
Resolution: invalid
Status: newclosed

Why you hide in your screenshot actual flag used?
If flags are not set stuff are simply copied.

in reply to:  3 comment:4 by wurongxin, 2 years ago

Replying to richardpl:

Why you hide in your screenshot actual flag used?
If flags are not set stuff are simply copied.

Oh, you are right. Sorry that I did not notice the flag is 0. Actually, I reported another one with the screenshot (https://trac.ffmpeg.org/attachment/ticket/8045/Screenshot%202019-07-28%20at%2010.00.01%20PM.png) without shadowing the flag.

Actually, I have other cases where flag is not 0. I will investigate further and report in this bug report later. Thanks for your prompt reply.


Note: See TracTickets for help on using tickets.