Opened 11 months ago

Closed 5 weeks ago

#7524 closed enhancement (fixed)

missing PCR timestamps in secondary streams with the MPEGTS muxer

Reported by: msiders Owned by:
Priority: normal Component: avformat
Version: git-master Keywords: mpegts
Cc: neon18@nngo.net Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Summary of the bug:

When using the MPEG-TS muxer only the primary stream has PCR timestamps. And this behaviour can't be enhanced to mark additional substreams. It would be desirable to be able to mark other streams with PCRs.

Change History (8)

comment:1 Changed 11 months ago by msiders

Hi,
I came up with a solution!

The current implementation of the MPEG-TS muxer only inserts PCR timestamps in the main stream. This stream is typically the video stream in a video service, or the audio stream in a radio service.

However, when multiple streams are mixed in the same MPEG-TS service, you may need to have more than one stream with time stamps. This is true when you will remux the service to create multiple services. For example, when you copy the different audio tracks from the service for creating additional radio services. Or when more than one video stream is included and in the remux you generate independent services.

To resolve this limitation, I created on myself a patch to insert the PCR timestamps in more than the first stream. This is completely optional, as it’s not a good idea to put PCRs in all streams (even if it’s not generate errors). Two new parameters are incorporated to mark all video streams and/or all audio streams.

The patch implements this optional behavior:
https://patchwork.ffmpeg.org/patch/10827/

I hope it will accepted.
Regards.
M.Sanders.

comment:2 Changed 11 months ago by msiders

Hi,

Is Baptiste Coudurier <baptiste.coudurier@gmail.com> the current maintainer of the MPEG-TS muxer?

I'm still waiting for someone to check this patch.
Regards.

comment:3 Changed 11 months ago by msiders

  • Keywords mpegtsenc added

comment:4 Changed 10 months ago by cehoyos

  • Keywords mpegtsenc pcr removed

comment:5 follow-up: Changed 10 months ago by msiders

Hi,

A new version of patch is provided:
https://patchwork.ffmpeg.org/patch/11093/

I hope it will accepted.
Regards.
M.Sanders.

Version 0, edited 10 months ago by msiders (next)

comment:6 in reply to: ↑ 5 Changed 10 months ago by msiders

A new version of patch is provided:
https://patchwork.ffmpeg.org/patch/11093/

Hi,

I don't received any feeback about my patch v2.

I'd like to receive some comments. Or that it was accepted.
Regards.

comment:7 Changed 9 months ago by neon18

  • Cc neon18@nngo.net added

comment:8 Changed 5 weeks ago by cus

  • Resolution set to fixed
  • Status changed from new to closed

You can mark streams to generate a PCR in them if you reference them in separate programs. So I think this is fixed in 88ac76be796025dfa7cc55124e881fbc59b7377a and d770e0f401e77ccd4640bbc805384f928d5de244. Reopen and update patch description if that is not enough.

Note: See TracTickets for help on using tickets.