Opened 3 years ago

Closed 3 years ago

#7248 closed defect (fixed)

Netflix/vmaf commit 47d0655 changes API of compute_vmaf again

Reported by: LigH Owned by:
Priority: important Component: build system
Version: git-master Keywords: libvmaf
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Related to ffmpeg trac ticket #6921 – but new:

vmaf commit 47d0655 adds two more parameters to compute_vmaf_score(..., int n_thread, int n_subsample)

The whole API may have to be treated as unstable.

Change History (7)

comment:1 by LigH, 3 years ago

Component: avfilterbuild system

comment:2 by LigH, 3 years ago

Summary: Netflix/vmaf commit 47d0655 changes API of compute_vmaf_score againNetflix/vmaf commit 47d0655 changes API of compute_vmaf again

comment:3 by LigH, 3 years ago

compute_vmaf() in wrapper/src/libvmaf.cpp and wrapper/src/libvmaf.h

comment:4 by LigH, 3 years ago

Keywords: api added; regression removed
Priority: normalimportant
Version: unspecifiedgit-master

I don't have the experience to create a correct diff file, so just quoting a suggestion by 'timothymowens':

Heads-up, I was able to get it to build by replacing this on line 169 of build\ffmpeg-git\libavfilter\vf_libvmaf.c:
s->ms_ssim, s->pool);
with this:
s->ms_ssim, s->pool, 0, 1);

Not a permanent solution, but will get me by until this issue is resolved correctly by ffmpeg/vmaf teams.

comment:5 by Carl Eugen Hoyos, 3 years ago

Keywords: api removed

The most important thing about this ticket is probably that we’ll have to remove this dependency if no stable api is provided, see also the discussion about the Turing library.

comment:6 by LigH, 3 years ago

And more changes to the VMAF API:

  • v1.3.7 {1b0f6ef}: added bool conf_interval
  • v1.3.8 {f5ea345}: changed to int enable_conf_interval

Does 'conf' mean "confusion"?

MABS clamps to a last stable libvmaf revision before all these changes now.

Last edited 3 years ago by LigH (previous) (diff)

comment:7 by Carl Eugen Hoyos, 3 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.