Opened 10 months ago

Last modified 10 months ago

#6929 new enhancement

Incorrect spacing in the realtime progress indicators in shell

Reported by: ZexaronS Owned by:
Priority: wish Component: ffmpeg
Version: git-master Keywords: logging
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Summary of the bug:

Some minor stuff can be annoying, but not annoying enough to warrant quick response, this has been on my mind for quite some time and I took this opportunity to do something about it.

I checked the source months ago, and again didn't (forgot) do anything at the time, but I still remember that the real time progress indicators are made up with several strings and when it all gets combined the spacing isn't consistent.

My biggest issue is with the lack of space between the number and the unit.

frame= 1318 fps=126 q=2.0 Lsize=   24180kB time=00:00:53.60 bitrate=3695.0kbits/s speed=5.14x

This is one way how I would prefer it: ([indicator]=[space]number[space]unit[space2x])

frame= 1318  fps= 126  q= 2.0  size= 24180 kB  time= 00:00:53.60  bitrate= 3695.0 kbits/s 
 speed= 5.14x

Or alternatively without =spaces

frame=1318  fps=126  q=2.0  size=24180 kB  time=00:00:53.60  bitrate=3695.0 kbits/s 
 speed=5.14x

Also, another bug, the "L" before "size=" appears after stopping the process with CTRL+C, also I don't remember if it also happens on normal finishing, right now I can't check since I'm running a very long one which won't be done for hours.

Patches should be submitted to the ffmpeg-devel mailing list and not this bug tracker.

Change History (3)

comment:1 Changed 10 months ago by Gyan

Also, another bug, the "L" before "size=" appears after stopping the process with CTRL+C, also I don't remember if it also happens on normal finishing

It does, and it's not a bug. The L indicates that the writing is done.

From ffmpeg.c:

   if (is_last_report)
       snprintf(buf + strlen(buf), sizeof(buf) - strlen(buf), "L");

comment:2 follow-up: Changed 10 months ago by Cigaes

You first say “Incorrect” and “isn't consistent”, but the way I read the rest of the message, it seems to me the real reason is “I would prefer”. Which is it? What is “incorrect” or “inconsistent” in the current display?

comment:3 in reply to: ↑ 2 Changed 10 months ago by ZexaronS

Replying to Cigaes:

You first say “Incorrect” and “isn't consistent”, but the way I read the rest of the message, it seems to me the real reason is “I would prefer”. Which is it? What is “incorrect” or “inconsistent” in the current display?

Sorry, it's just "not optimal", I was writing this a bit late yesterday.

You can see there's a lot of spaces between size and the number, and you see one space between frame= and the number, while others have no spaces. But everything has no space between units either, that one is not an inconsistency but just something I think is too tight.

It may be a little bit of personal bias because I'm a very shortsighted person and speed=424230kb/s can be harder to distinguish clearly unless having to focus-in on the screen specifically for that, it's not about lazyness, it's about multitasking and while it seems like a minor thing, it adds up when you combine it the rest of the workflow.

Last edited 10 months ago by ZexaronS (previous) (diff)
Note: See TracTickets for help on using tickets.