libavfilter/signature_lookup.c:494: suspicious compare ?

[dcb]

ffmpeg-3.4/libavfilter/signature_lookup.c:494]: (warning) Result of operator '|' is always true if one operand is non-zero. Did you intend to use '&'?

Source code is

        if (meandist < minmeandist ||
                status == STATUS_END_REACHED | STATUS_BEGIN_REACHED ||
                mode == MODE_FAST){

maybe better code

        if (meandist < minmeandist ||
                status == (STATUS_END_REACHED | STATUS_BEGIN_REACHED) ||
                mode == MODE_FAST){

[Carl Eugen Hoyos]

Please send your patches made with git format-patch to the FFmpeg development mailing list, patches (and patch suggestions) are ignored here.

How did you find the issues?

[dcb]

How did you find the issues?

A static analyser called cppcheck, available from sourceforge.

I find it very useful for C and C++ development. It catches
a lot of problems compilers don't find.

[Balling]

Merged in #8156.

[Balling]

What the... Okay.

[Balling]

Replying to cehoyos:
Suspecious? Really? Now it never become 0, so mode is never checked. "Result of operator '|' is always true if one operand is non-zero." And == have higher precedence. In this case STATUS_BEGIN_REACHED is 2. So...

[Carl Eugen Hoyos]

Replying to Balling:

Replying to cehoyos:
Suspecious? Really?

You are asking me questions but I have no idea what you want to ask...

[Balling]

Replying to cehoyos:

Replying to Balling:

Replying to cehoyos:
Suspecious? Really?

You are asking me questions but I have no idea what you want to ask...

I mean brackets obviously should be there. Or you can put 1 insteed of all

status == (STATUS_END_REACHED | STATUS_BEGIN_REACHED)

[Carl Eugen Hoyos]

Now I have two questions:
Why do you believe I disagree?
Why didn't you sent a patch made with git format-patch to the development mailing list?

[Balling]

Replying to cehoyos:

Now I have two questions:
Why do you believe I disagree?
Why didn't you sent a patch made with git format-patch to the development mailing list?

Well, because it is already midnight here?

[Balling]

Patch is here: ​https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210524010024.4928-1-val.zapod.vz@gmail.com/

Wow, your mailing list is also buggy, sometimes it processes patches in real time and sometimes not! WTF. P.S. sorry for a duplication too.