Opened 3 years ago

Closed 13 months ago

#6741 closed defect (fixed)

ffmpeg-3.4/libavfilter/vf_cover_rect.c:155: suspicious if ?

Reported by: dcb Owned by:
Priority: normal Component: avfilter
Version: git-master Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description (last modified by cehoyos)

ffmpeg-3.4/libavfilter/vf_cover_rect.c:155] -> [ffmpeg-3.4/libavfilter/vf_cover_rect.c:155]: (style) Same expression on both sides of ||.

Source code is

    if (!xendptr || *xendptr || !yendptr || *yendptr ||
        !wendptr || *wendptr || !hendptr || !hendptr

maybe better code

    if (!xendptr || *xendptr || !yendptr || *yendptr ||
        !wendptr || *wendptr || !hendptr || !*hendptr

Change History (1)

comment:1 Changed 13 months ago by cehoyos

  • Component changed from undetermined to avfilter
  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from unspecified to git-master
Note: See TracTickets for help on using tickets.