Opened 5 years ago

Closed 5 years ago

#6076 closed defect (wontfix)

concat format doesn't allow spaces in file names

Reported by: Kyle Repinski Owned by:
Priority: normal Component: avformat
Version: git-master Keywords: concat
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Summary of the bug:

The concat(dec) format doesn't allow spaces in file names unless the "-safe 0" argument is passed, as it deems spaces to be an "unsafe character". The problem is allowing unsafe file names (by passing the -safe 0 argument) also enables support for absolute paths, whereas "safe" file names may only be relative paths. Spaces are an everyday occurrence in file and folder names and should be allowed by default without having to enable support for absolute file paths.

How to reproduce:

% ffmpeg -f concat -i playlist.txt ... output
ffmpeg version N-83049-ge71b811 (built on 2017/01/11)

Example "unsafe" playlist.txt:

file 01\ .flac
file 02.flac

Change History (6)

comment:1 by Carl Eugen Hoyos, 5 years ago

Keywords: concat added; concatdec removed
Summary: concatdec format doesn't allow spaces in file namesconcat format doesn't allow spaces in file names

Assuming you agree that this didn't happen by accident please send a patch (made with git format-patch) with your requested change to the development mailing list, discussing it here makes no sense.

in reply to:  1 ; comment:2 by Kyle Repinski, 5 years ago

Replying to cehoyos:

Assuming you agree that this didn't happen by accident please send a patch (made with git format-patch) with your requested change to the development mailing list, discussing it here makes no sense.

Uh, I wasn't aware it was the user's responsibility to create patches and that this tracker is not supposed to be used. Correct me if I'm mistaken please.

I agree this isn't an "accident", the behavior matches the documentation, but it doesn't make any sense. I believe it was overlooked and is a mistake.

Last edited 5 years ago by Kyle Repinski (previous) (diff)

comment:3 by Nicolas George, 5 years ago

Spaces in file names is a very bad idea in many situations. The concat demuxer is very conservative by default; implementing fine-grained policies would be way beyond its scope, and not everybody has the same needs as you.

If you get file names from untrusted sources, you need to validate them according to your specific security requirements.

in reply to:  2 ; comment:4 by Carl Eugen Hoyos, 5 years ago

Replying to MWisBest:

Replying to cehoyos:

Assuming you agree that this didn't happen by accident please send a patch (made with git format-patch) with your requested change to the development mailing list, discussing it here makes no sense.

Uh, I wasn't aware it was the user's responsibility to create patches and that this tracker is not supposed to be used. Correct me if I'm mistaken please.

It is not supposed to be used for patches and not for features that you want removed.

I agree this isn't an "accident", the behavior matches the documentation

That's not what I meant.

but it doesn't make any sense. I believe it was overlooked and is a mistake.

In this case, the report is of course valid but wont-fix.

Last edited 5 years ago by Carl Eugen Hoyos (previous) (diff)

in reply to:  4 comment:5 by Kyle Repinski, 5 years ago

Replying to cehoyos:

Replying to MWisBest:

Replying to cehoyos:

Assuming you agree that this didn't happen by accident please send a patch (made with git format-patch) with your requested change to the development mailing list, discussing it here makes no sense.

Uh, I wasn't aware it was the user's responsibility to create patches and that this tracker is not supposed to be used. Correct me if I'm mistaken please.

It is not supposed to be used for patches and not for features that you want removed.

I agree this isn't an "accident", the behavior matches the documentation

That's not what I meant.

but it doesn't make any sense. I believe it was overlooked and is a mistake.

In this case, the report is of course valid but wont-fix.

Alright, that's fair. Thank you for the clarification.

comment:6 by Carl Eugen Hoyos, 5 years ago

Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.