Opened 5 years ago

Closed 5 years ago

#550 closed defect (fixed)

Can not store AMR mode 15 (no data) packet through avformat - ffmpeg 0.6.3

Reported by: ilevin Owned by:
Priority: normal Component: avformat
Version: git-master Keywords: mov AMR
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Logic in movenc.c, function ff_mov_write_packet(), prevents putting no data AMR NB packets - the check will consider such a packet as a multi packet incorrectly. Attached is a simple fix for the issue.

Attachments (1)

movenc.c.diff (1.5 KB) - added by ilevin 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by ilevin

comment:1 Changed 5 years ago by cehoyos

Can't you simply add "1" to the entries in packed_size that need it to make this patch smaller?

comment:2 Changed 5 years ago by ilevin

You are right, I could, but I wanted to preserve the array with the logical meaning of "how much of payload each AMR mode packet carries", instead of adding the TOC byte to the size.

comment:3 Changed 5 years ago by cehoyos

  • Keywords mov added; mode 15 removed
  • Status changed from new to open
  • Version changed from unspecified to git-master

I suggest you clone current FFmpeg, change the required value in the array - no additional comment needed afaict - and send a patch to ffmpeg-devel.

(I cannot comment on the issues you point out in the other ticket.)

comment:4 Changed 5 years ago by cehoyos

  • Resolution set to fixed
  • Status changed from open to closed

I committed a patch to current git head, please reopen if this does not fix the issue you saw.

Note: See TracTickets for help on using tickets.