Opened 6 years ago

Closed 5 years ago

#5304 closed defect (fixed)

mpegts broken when using copy

Reported by: Julian Gardner Owned by:
Priority: important Component: avformat
Version: git-master Keywords: mpegts regression
Cc: Michael Niedermayer Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

ffmpeg -i tenhd.ts -c:v copy -c:a copy -y -f mpegts temhd_78949.ts

output is as it should be, no errors, no warnings, same as N-73662-g4e169ec

Now the problem is that we use a professional streamer, Edgeware WTV-2X and with version 73662 everything works, with any version after the edgeware rejects the streams.

I have gone through the repository using bisect and run the above command on each version that bisect checks outs, and here are the md5 for each file.

Working
3acc816241628ec537523906e87158b5 tenhd_72632.ts
3acc816241628ec537523906e87158b5 tenhd_73418.ts
3acc816241628ec537523906e87158b5 tenhd_73614.ts
3acc816241628ec537523906e87158b5 tenhd_73662.ts

Not Working
424eae4536cba80e21d17b3fb66fdadc tenhd_73664.ts
424eae4536cba80e21d17b3fb66fdadc tenhd_73668.ts
424eae4536cba80e21d17b3fb66fdadc tenhd_73674.ts
424eae4536cba80e21d17b3fb66fdadc tenhd_73687.ts
424eae4536cba80e21d17b3fb66fdadc tenhd_73712.ts
424eae4536cba80e21d17b3fb66fdadc tenhd_73811.ts
424eae4536cba80e21d17b3fb66fdadc tenhd_74205.ts
424eae4536cba80e21d17b3fb66fdadc tenhd_75779.ts
424eae4536cba80e21d17b3fb66fdadc tenhd_78926.ts
424eae4536cba80e21d17b3fb66fdadc tenhd_78949.ts

Now with 1 commit removed.
3acc816241628ec537523906e87158b5 tenhd_78949.ts

See
https://github.com/FFmpeg/FFmpeg/commit/4512ee78e19fdb011bdec1b3a8dc0b315c82a81e#diff-09799f46e6bfb687342824ca9a0481a0

Removing this commit solves the problem I am having but I have not investigated why this causes the problems.

Attachments (1)

tenhd.ts (2.0 MB ) - added by Julian Gardner 6 years ago.
test file used to show mpegts problem

Download all attachments as: .zip

Change History (10)

comment:1 by Carl Eugen Hoyos, 6 years ago

Keywords: mpegts regression added; mpegtsenc removed
Priority: criticalimportant

My git neither recognizes 3acc816241628ec537523906e87158b5 nor 424eae4536cba80e21d17b3fb66fdadc
Please test current FFmpeg git head and provide both your command line and the complete, uncut console output and an input sample to make this a valid ticket.

comment:2 by Julian Gardner, 6 years ago

Did you read the message

1.424eae4536cba80e21d17b3fb66fdadc and 3acc816241628ec537523906e87158b5 are MD5 checksums. See "and here are the md5 for each file"

see version above "git-master"

output is not sent as the output of all versions shows no errors or warning but here goes knock yourself out

ffmpeg version N-78949-g6f5048f Copyright (c) 2000-2016 the FFmpeg developers
  built with gcc 4.8 (Ubuntu 4.8.2-19ubuntu1)
  configuration: --bindir=/home/encoder/bin --enable-gpl --enable-version3 --enable-nonfree --disable-dxva2 --disable-vaapi --disable-vda --disable-vdpau --disable-libxcb --enable-libmp3lame
  libavutil      55. 19.100 / 55. 19.100
  libavcodec     57. 27.101 / 57. 27.101
  libavformat    57. 28.100 / 57. 28.100
  libavdevice    57.  0.101 / 57.  0.101
  libavfilter     6. 39.100 /  6. 39.100
  libswscale      4.  0.100 /  4.  0.100
  libswresample   2.  0.101 /  2.  0.101
  libpostproc 54.  0.100 / 54.  0.100
Input #0, mpegts, from 'tenhd.ts':
  Duration: 00:00:16.70, start: 86.328000, bitrate: 998 kb/s
  Program 1
    Metadata:
      service_name    : Ten Sports HD
      service_provider: v-play
    Stream #0:0[0x100]: Video: h264 (High) ([27][0][0][0] / 0x001B), yuv420p, 960x540 [SAR 1:1 DAR 16:9], 25 fps, 25 tbr, 90k tbn, 50 tbc
    Stream #0:1[0x101]: Audio: aac (LC) ([15][0][0][0] / 0x000F), 32000 Hz, stereo, fltp, 96 kb/s
Output #0, mpegts, to 'tenhd_78949.ts':
  Metadata:
    encoder         : Lavf57.28.100
    Stream #0:0: Video: h264 ([27][0][0][0] / 0x001B), yuv420p, 960x540 [SAR 1:1 DAR 16:9], q=2-31, 25 fps, 25 tbr, 90k tbn, 25 tbc
    Stream #0:1: Audio: aac (LC) ([15][0][0][0] / 0x000F), 32000 Hz, stereo, 96 kb/s
Stream mapping:
  Stream #0:0 -> #0:0 (copy)
  Stream #0:1 -> #0:1 (copy)
Press [q] to stop, [?] for help
frame=  282 fps=0.0 q=-1.0 Lsize=    1484kB time=00:00:16.58 bitrate= 733.0kbits/s speed= 487x
video:1149kB audio:192kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 10.602725%

The git commit is included in the link at the bottom of the message.

joolz
Why do i bother, all the information you needed is in the original post, please READ before plowing in with the standard, "WE NEED FULL UNCUT"

Last edited 6 years ago by Carl Eugen Hoyos (previous) (diff)

comment:3 by Carl Eugen Hoyos, 6 years ago

(Any reason you did not want to provide the command line together with the console output?)

Please provide an input sample that allows to reproduce the issue.

by Julian Gardner, 6 years ago

Attachment: tenhd.ts added

test file used to show mpegts problem

comment:4 by Julian Gardner, 6 years ago

YES as the output from all 10 versions i tested are clean for warning and errors, which is why i used md5 to show the problem.

file attached

in reply to:  description comment:5 by Carl Eugen Hoyos, 6 years ago

Replying to joolzg:

output is as it should be, no errors, no warnings, same as N-73662-g4e169ec

It actually is N-73662-g4e160ec

comment:6 by Julian Gardner, 6 years ago

Seriously your gonna pull up a typo when YOU did not even bother to read the 1st message.

comment:7 by Michael Niedermayer, 6 years ago

Cc: Michael Niedermayer added

the uploaded file does not allow to reproduce the problem. It does not work with older versions either, older versions just completely skip the video stream which is incomplete in the sample file. Please provide a sample file that allows to reproduce the problem

in reply to:  7 comment:8 by Michael Niedermayer, 6 years ago

Replying to michael:

the uploaded file does not allow to reproduce the problem. It does not work with older versions either, older versions just completely skip the video stream which is incomplete in the sample file. Please provide a sample file that allows to reproduce the problem

Sorry, the sample is ok, just needs -analyzeduration 99M

comment:9 by Michael Niedermayer, 5 years ago

Resolution: fixed
Status: newclosed

The file seems to work fine with git master now, so some other bugfix must have fixed this.

Note: See TracTickets for help on using tickets.