Opened 2 years ago

Closed 22 months ago

#5190 closed defect (fixed)

RSS is broken

Reported by: Lord_D Owned by: beastd
Priority: normal Component: website
Version: unspecified Keywords: rss
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

News RSS is broken for some time: https://ffmpeg.org/main.rss

Change History (3)

comment:1 Changed 2 years ago by cehoyos

  • Keywords website feed removed

comment:2 Changed 22 months ago by beastd

  • Owner set to beastd
  • Status changed from new to open

I have a worked out a fix for this.

Will send it for review to the ffmpeg-devel mailing list soon.

comment:3 Changed 22 months ago by beastd

  • Resolution set to fixed
  • Status changed from open to closed

Fixed by Michael in ffmpeg-web repo commit 629c2c7 (and f6336ea).

I am sorry I forgot to follow up here and for the resulting duplicated work.

For the record this were my patches:

From 24ec10ef9c163ab7f8df774cbf9d185877b8e0ad Mon Sep 17 00:00:00 2001
From: Alexander Strasser <eclipse7@gmx.net>
Date: Fri, 18 Mar 2016 01:03:04 +0100
Subject: [PATCH 1/2] web/index: Use ampersand entity instead of &

---
 src/index | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/index b/src/index
index c469028..ff0caf2 100644
--- a/src/index
+++ b/src/index
@@ -147,7 +147,7 @@
     feedback or breakage reports through our <a href="https://trac.ffmpeg.org/">bug tracker</a>.
   </p>
 
-  <h3 id="thanks_sponsor_0001">October 13th, 2015, Telepoint & MediaHub are now supporting our project</h3>
+  <h3 id="thanks_sponsor_0001">October 13th, 2015, Telepoint &amp; MediaHub are now supporting our project</h3>
   <p>
     A big thank you note goes to our newest supporters: MediaHub and Telepoint.
     Both companies have donated a dedicated server with free of charge internet
--

From 4751fbb9c9707a9e387a25ec70737765ce54e2a4 Mon Sep 17 00:00:00 2001
From: Alexander Strasser <eclipse7@gmx.net>
Date: Fri, 18 Mar 2016 01:04:12 +0100
Subject: [PATCH 2/2] web/Makefile: Adjust patterns for matching begin/end of
 the news part

Repair RSS generator.

Regression of commits
  b95c6584576e004e56d94fcdf6679d051a043bf4
  2978eb836eb493c8fecfd183b607b2074bcfbb02

The former broke the feed completely while the latter wasn't that
noticeable AFAICT.
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index f13a36f..e07345d 100644
--- a/Makefile
+++ b/Makefile
@@ -44,8 +44,8 @@ $(RSS_TARGET): htdocs/index.html
 	echo '    <link>http://ffmpeg.org</link>' >> $@
 	echo '    <description>FFmpeg RSS</description>' >> $@
 	echo '    <atom:link href="http://ffmpeg.org/main.rss" rel="self" type="application/rss+xml" />' >> $@
-	awk '/<a *id=".*" *> *<\/a> *<h3>.*20.., *.*<\/h3>/ { p = 1 } /<h1>Older entries are in the .*news archive/ { p = 0 } p' $< \
-        | sed 'sX<a *id="\(.*\)" *> *</a> *<h3>\(.*20..\), *\(.*\)</h3>X\
+	awk '/<h3 .*=".*" *>.*20..,*.*<\/h3>/ { p = 1 } /<div class="text-right">/ { p = 0 } p' $< \
+        | sed 'sX<h3 *id="\(.*\)" *>\(.*20..\), *\(.*\)</h3>X\
         ]]></content:encoded>\
     </item>\
     <item>\
-- 
Note: See TracTickets for help on using tickets.