Opened 9 years ago

Closed 9 years ago

#4802 closed defect (fixed)

Non atomic generation of m3u8 file

Reported by: Manuel Guesdon Owned by:
Priority: important Component: avformat
Version: git-master Keywords: segment regression
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Generation of m3u8 file in libavformat/segment.c is not atomic so one may get a partial m3u8 file when reading it.
In libavformat/hlsenc.c the operation is atomic (write to tmp file and next rename).

Change History (4)

comment:1 by Carl Eugen Hoyos, 9 years ago

Keywords: segment added; atomic write m3u8 removed
Priority: important → normal

Is this a regression?

comment:2 by Manuel Guesdon, 9 years ago

It's a regression compared to 1.0.10.
In 1.0.10 new segments are appended so the problem does not appear.
In newer versions, the file is entirely rewritten to adjust the #EXT-X-TARGETDURATION.

Last edited 9 years ago by Manuel Guesdon (previous) (diff)

comment:3 by Carl Eugen Hoyos, 9 years ago

Keywords: regression added
Priority: normal → important

comment:4 by Michael Niedermayer, 9 years ago

Resolution: → fixed
Status: new → closed

Fixed in e2b19a533dbb4cb0fba85261ea835316381bc907

Note: See TracTickets for help on using tickets.