Opened 12 years ago

Closed 12 years ago

#4199 closed defect (fixed)

When omitting '--shlibdir=' for configure, SHLIBDIR expands to $DESTDIR$DESTDIR...

Reported by: friedinsugar Owned by:
Priority: important Component: build system
Version: git-master Keywords: regression
Cc: Michael Niedermayer Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: no

Description

Summary of the bug:
In the generated config.mak,
SHLIBDIR expands to
$(DESTDIR)$(DESTDIR)...

How to reproduce:
Run configure without '--shlibdir='

Possible cause of bug:
the following line in the 'configure' file:
shlibdir_default='${LIBDIR}'

should be instead
shlibdir_default='${libdir_default}'

but I need a second opinion.

Change History (8)

comment:1 by Carl Eugen Hoyos, 12 years ago

Keywords: regression added

How can I reproduce this?
If I run ./configure (without --shlibdir), SHLIBDIR expands to /usr/local/lib which is what I expected.

comment:2 by iive, 12 years ago

$DESTDIR is used by packaging to redirect the installation to somewhere else than the root of the filesystem.
You usually do something like make install DESTDIR=/tmp/package .

I think the fix should be:
shlibdir_default='${libdir}'

as we have:
LIBDIR=\$(DESTDIR)$libdir
SHLIBDIR=\$(DESTDIR)$shlibdir

comment:3 by Carl Eugen Hoyos, 12 years ago

Reproduced by developer: set
Status: new → open

comment:5 by Michael Niedermayer, 12 years ago

Cc: Michael Niedermayer added

comment:6 by Pär Forsling, 12 years ago

By changing shlibdir_default to:
shlibdir_default='${prefix}/lib'
DESTDIR seems to work as intended.

in reply to:  6 comment:7 by Michael Niedermayer, 12 years ago

Replying to electropura:

By changing shlibdir_default to:
shlibdir_default='${prefix}/lib'
DESTDIR seems to work as intended.

This would break ticket 4183

comment:8 by Michael Niedermayer, 12 years ago

Resolution: → fixed
Status: open → closed

Fixed in d1c6b7b2d1ef2fc0ada6bcb49c516e20e3627525

Note: See TracTickets for help on using tickets.