Changes between Initial Version and Version 1 of Ticket #3947, comment 2


Ignore:
Timestamp:
Sep 13, 2014, 3:31:22 PM (5 years ago)
Author:
francois.visagie@gmail.com
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3947, comment 2

    initial v1  
    44Since '-level x.y' seems to correctly set that configuration - including refs - is there the possibility that the handling of '-x264opts level=x.y' could be directed to that of '-level x.y'?
    55
    6 In any case, while I'm not able to analyse the code, for three reasons there does seem to be the possibility that the further configuration is correctly set by '-x264opts level', but (accidentally) partially overwritten by ffmpeg subsequently. 1) 'x264 --level' correctly sets the level-specific configuration, including refs, which creates the possibility that libx264 might do the same. 2) When not given a '-refs' value, ffmpeg always defaults to 16. 3) All encodes done with '-x264opts level' and without '-refs' have refs=16. Together these give rise to the possibility that when '-x264opts level' is used, libx264 correctly sets the configuration, but that ffmpeg subsequently overwrites refs with its default of 16.
     6In any case, while I'm not able to analyse the code, for three reasons there does seem to be the possibility that the further configuration is correctly set by '-x264opts level', but (accidentally) partially overwritten by ffmpeg. 1) 'x264 --level' correctly sets the level-specific configuration, including refs, which creates the possibility that libx264 might do the same. 2) When not given a '-refs' value, ffmpeg always defaults to 16. 3) All encodes done with '-x264opts level' and without '-refs' have refs=16. Together these give rise to the possibility that when '-x264opts level' is used, libx264 correctly sets the configuration, but that ffmpeg overwrites refs with its default of 16.
    77
    88If that is the case, ffmpeg's logic could be changed to not pass a refs value to libx264 when either of '-level' or '-x264opts level' is used, and no '-refs' value is provided.