Opened 7 years ago

Closed 7 years ago

#3613 closed defect (fixed)

transcode_aac test fails to build

Reported by: Brad Smith Owned by: Timothy Gu
Priority: normal Component: documentation
Version: git-master Keywords: examples
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: no

Description (last modified by Timothy Gu)

Updating to the FFmpeg 2.2 branch I noticed one of the tests (transcode_aac) fails to build.

doc/examples/transcode_aac.c:56: error: type qualifiers ignored on function return type

Change History (8)

comment:1 by Timothy Gu, 7 years ago

Component: undetermineddocumentation

Code:

static char *const get_error_text(const int error) { ... }

It should be static const char *get_error_text.

comment:2 by Brad Smith, 7 years ago

And that does build.

comment:3 by Brad Smith, 7 years ago

Please commit the fix as mentioned by Timothy.

comment:4 by Timothy Gu, 7 years ago

Description: modified (diff)
Owner: set to Timothy Gu
Status: newopen

I will send a patch in ~2 days (because I forgot about this ticket). Anyway thanks for the confirmation.

comment:5 by Brad Smith, 7 years ago

ping.

comment:6 by Timothy Gu, 7 years ago

Sorry for the delay. Patch sent.

comment:7 by Timothy Gu, 7 years ago

Keywords: examples added
Reproduced by developer: set
Version: 2.2.1git-master

comment:8 by Timothy Gu, 7 years ago

Resolution: fixed
Status: openclosed

Fixed in http://git.videolan.org/?p=ffmpeg.git;a=commit;h=9f02a2b2240028de6bf48659170ea697f393a2ee. 2.3.2 and 2.2.7 will receive this bug fix (2.2.6 was just released 5 hours ago, sorry the patch didn't make it.)

Note: See TracTickets for help on using tickets.