Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#299 closed defect (fixed)

ffmpeg crashes with -vf mp=boxblur=100:100

Reported by: ami_stuff Owned by:
Priority: normal Component: avfilter
Version: git Keywords: mpfilter
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: yes

Description

It seems like there should be added a check for max value allowed by mplayer's boxblur filter, because otherwise it crashes.

I have no debug ffmpeg build, so no gdb output.

http://samples.mplayerhq.hu/V-codecs/DX50-DivX5/01.avi

C:\>ffmpeg -i 01.avi -vf mp=boxblur=100:100 out.avi
ffmpeg version N-30956-g81ef892, Copyright (c) 2000-2011 the FFmpeg developers
  built on Jun 22 2011 17:34:15 with gcc 4.5.3
  configuration: --enable-gpl --enable-version3 --enable-memalign-hack --enable-
runtime-cpudetect --enable-avisynth --enable-bzlib --enable-frei0r --enable-libo
pencore-amrnb --enable-libopencore-amrwb --enable-libfreetype --enable-libgsm --
enable-libmp3lame --enable-libopenjpeg --enable-librtmp --enable-libschroedinger
 --enable-libspeex --enable-libtheora --enable-libvorbis --enable-libvpx --enabl
e-libx264 --enable-libxavs --enable-libxvid --enable-zlib
  libavutil    51.  9. 1 / 51.  9. 1
  libavcodec   53.  7. 0 / 53.  7. 0
  libavformat  53.  4. 0 / 53.  4. 0
  libavdevice  53.  1. 1 / 53.  1. 1
  libavfilter   2. 23. 0 /  2. 23. 0
  libswscale    2.  0. 0 /  2.  0. 0
  libpostproc  51.  2. 0 / 51.  2. 0

Seems stream 0 codec frame rate differs from container frame rate: 30000.00 (300
00/1) -> 23.98 (24000/1001)
Input #0, avi, from '01.avi':
  Duration: 00:00:10.01, start: 0.000000, bitrate: 327 kb/s
    Stream #0.0: Video: mpeg4, yuv420p, 320x240 [PAR 1:1 DAR 4:3], 23.98 fps, 23
.98 tbr, 23.98 tbn, 30k tbc
[buffer @ 01E63500] w:320 h:240 pixfmt:yuv420p tb:1/1000000 sar:1/1 sws_param:
[mp @ 01E63A20] This is a unholy filter, it will be purified by the ffmpeg exorc
ist team
which will change its syntax from dark -vf mp to light -vf.
Thou shalst not make spells or scripts that depend on it
Output #0, avi, to 'out.avi':
  Metadata:
    ISFT            : Lavf53.4.0
    Stream #0.0: Video: mpeg4, yuv420p, 320x240 [PAR 1:1 DAR 4:3], q=2-31, 200 k
b/s, 23.98 tbn, 23.98 tbc
Stream mapping:
  Stream #0.0 -> #0.0
Press [q] to stop, [?] for help

C:\>

Change History (2)

comment:1 Changed 5 years ago by saste

  • Analyzed by developer set
  • Component changed from undetermined to avfilter
  • Reproduced by developer set
  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from unspecified to git

The filter has been removed in place of a native libavfilter implementation:

commit 4bd28579e51a358fc6d26040c4ccd6aefb5a90ef
Author: Stefano Sabatini <stefano.sabatini-lala@poste.it>
Date:   Sat Jul 9 18:23:02 2011 +0200

    vf_mp: remove boxblur wrapper
    
    It is natively included in libavfilter.

The native boxblur filter implements a check on invalid values, so won't crash in case they're too big.

comment:2 Changed 4 years ago by cehoyos

  • Keywords mpfilter added
Note: See TracTickets for help on using tickets.