Opened 7 years ago

Closed 6 years ago

#294 closed defect (wontfix)

deinterlacer does not clear interlaced_frame flag

Reported by: Fritz Owned by:
Priority: normal Component: undetermined
Version: git Keywords: deinterlace libav
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

transcoding to a y4m file. used -deinterlace which did deinterlace the video, but the y4m header has the interlaced bit set. This also occurs with libav and yadif.

This patch fixes the problem with -deinterlace by clearing the bit on a successful deinterlace.

Looking through yadif it appears that the flag is cleared, but it was still showing up on the file. I did not pursue it further.

Attachments (1)

deinterlace.patch (380 bytes) - added by Fritz 7 years ago.
patch to clear interlaced_frame flag when using -deinterlace

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by Fritz

patch to clear interlaced_frame flag when using -deinterlace

comment:1 Changed 7 years ago by Fritz

file used
http://samples.mplayerhq.hu/MPEG2/interlaced/koncercik.mpg

ffmpeg -i koncercik.mpg -an -y -pix_fmt yuv420p -deinterlace koncercik.y4m

comment:2 Changed 7 years ago by michael

writing into the decoders coded_frame is not a good idea. Iam not saying it does break something but its risky / not proper

comment:3 Changed 7 years ago by michael

btw, i would suggest you use -vf yadif which does a better job at deinterlacing and should set the flags correctly

comment:4 Changed 6 years ago by michael

  • Resolution set to wontfix
  • Status changed from new to closed

Closing as -deinterlace is deprecated now and it should work with the video filters. If it doesnt work with -vf ... then please open a seperate ticket for that.
That said if someone wants to implement this for the deprecated option, iam not opposed but the patch must not write into things that its not supposed to write into ...

Note: See TracTickets for help on using tickets.