mts2: green artifacts (regression)

[ami_stuff]

git-b5e5ed8 12-Mar-2013 - ok
git-9efcfbe 13-Mar-2013 - bad

​http://samples.mplayerhq.hu/V-codecs/MTS2/ScreenCapture.xesc

C:\>ffmpeg -i ScreenCapture.xesc out.avi
ffmpeg version N-51683-g9dc88ac Copyright (c) 2000-2013 the FFmpeg developers
  built on Apr  8 2013 21:19:21 with gcc 4.8.0 (GCC)
  configuration: --enable-gpl --enable-version3 --disable-w32threads --enable-av
isynth --enable-bzlib --enable-fontconfig --enable-frei0r --enable-gnutls --enab
le-iconv --enable-libass --enable-libbluray --enable-libcaca --enable-libfreetyp
e --enable-libgsm --enable-libilbc --enable-libmp3lame --enable-libopencore-amrn
b --enable-libopencore-amrwb --enable-libopenjpeg --enable-libopus --enable-libr
tmp --enable-libschroedinger --enable-libsoxr --enable-libspeex --enable-libtheo
ra --enable-libtwolame --enable-libvo-aacenc --enable-libvo-amrwbenc --enable-li
bvorbis --enable-libvpx --enable-libx264 --enable-libxavs --enable-libxvid --ena
ble-zlib
  libavutil      52. 25.100 / 52. 25.100
  libavcodec     55.  2.100 / 55.  2.100
  libavformat    55.  1.100 / 55.  1.100
  libavdevice    55.  0.100 / 55.  0.100
  libavfilter     3. 49.101 /  3. 49.101
  libswscale      2.  2.100 /  2.  2.100
  libswresample   0. 17.102 /  0. 17.102
  libpostproc    52.  2.100 / 52.  2.100
Input #0, asf, from 'ScreenCapture.xesc':
  Metadata:
    WMFSDKNeeded    : 0.0.0.0000
    WMFSDKVersion   : 12.0.7600.16385
    IsVBR           : 0
  Duration: 00:00:08.67, start: 0.000000, bitrate: 565 kb/s
    Stream #0:0(eng): Video: mts2 (MTS2 / 0x3253544D), yuv444p, 1172x852, 30000
kb/s, 15.08 tbr, 1k tbn, 1k tbc
Output #0, avi, to 'out.avi':
  Metadata:
    WMFSDKNeeded    : 0.0.0.0000
    WMFSDKVersion   : 12.0.7600.16385
    IsVBR           : 0
    ISFT            : Lavf55.1.100
    Stream #0:0(eng): Video: mpeg4 (FMP4 / 0x34504D46), yuv420p, 1172x852, q=2-3
1, 200 kb/s, 15.08 tbn, 15.08 tbc
Stream mapping:
  Stream #0:0 -> #0:0 (mts2 -> mpeg4)
Press [q] to stop, [?] for help
Input stream #0:0 frame changed from size:1172x852 fmt:yuv444p to size:1172x852
fmt:yuv420p
[mts2 @ 026e7ee0] Picture changed from size:1172x852 fmt:yuv420p to size:1172x85
2 fmt:yuv444p in reget buffer()
Input stream #0:0 frame changed from size:1172x852 fmt:yuv420p to size:1172x852
fmt:yuv444p
frame=    8 fps=0.0 q=2.0 size=     120kB time=00:00:00.66 bitrate=1481.5kbits/s
frame=   24 fps= 24 q=2.0 size=     138kB time=00:00:01.72 bitrate= 657.1kbits/s
frame=   39 fps= 26 q=2.0 size=     278kB time=00:00:02.71 bitrate= 837.1kbits/s
frame=   54 fps= 27 q=4.2 size=     396kB time=00:00:03.71 bitrate= 874.8kbits/s
frame=   69 fps= 27 q=21.2 size=     487kB time=00:00:04.70 bitrate= 847.4kbits/
frame=   85 fps= 28 q=31.0 size=     540kB time=00:00:05.76 bitrate= 766.4kbits/
frame=   97 fps= 27 q=31.0 size=     631kB time=00:00:06.62 bitrate= 779.3kbits/
frame=  111 fps= 27 q=31.0 size=     778kB time=00:00:07.55 bitrate= 843.6kbits/
frame=  126 fps= 28 q=31.0 size=     856kB time=00:00:08.55 bitrate= 819.9kbits/
frame=  128 fps= 27 q=31.0 Lsize=     862kB time=00:00:08.68 bitrate= 813.5kbits
/s
video:854kB audio:0kB subtitle:0 global headers:0kB muxing overhead 1.019520%

[Carl Eugen Hoyos]

Regression since 36685c3 / 15ec045

[Elon Musk]

Really, I can't understand why would that commit/merge be cause of bug.

[Carl Eugen Hoyos]

Using ffplay, this is a regression since 36685c3, using ffmpeg, this is a regression since 32fdfdf

[Elon Musk]

Fixed in 310bf283542ff81a9ec8fa7492fe7d625e80562f

The default pix_fmt set in frame in private decoder struct was 0 which maps to yuv420p.