Changes between Initial Version and Version 1 of Ticket #2298, comment 8


Ignore:
Timestamp:
Feb 23, 2013, 9:09:33 PM (3 years ago)
Author:
reimar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2298, comment 8

    initial v1  
    22I'm quite sure the issue is in a missing EOF check. 
    33However in addition the valgrind numbers you quote give a completely wrong impression, it is not possible to allocate than much data, this is just a huge number of reallocs. 
    4 I do not think there allocation ever becomes unreasonably large, however we do have a av_max_alloc function and I have a suspicion this might be a user error, if a user does not want large allocations they should forbid them (though I admit there might be a good argument to be made to default to a lower value on 32 bit systems). 
     4I do not think the allocation ever becomes unreasonably large, however we do have a av_max_alloc function and I have a suspicion this might be a user error, if a user does not want large allocations they should forbid them (though I admit there might be a good argument to be made to default to a lower value on 32 bit systems). 
     5The CPU usage is a different issue, and that is due to the second loop, which in the worst case iterates 2 billion times.