Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1761 closed defect (invalid)

--enable-encoder=libx264 does nothing

Reported by: JunCTionS Owned by:
Priority: normal Component: build system
Version: git-master Keywords: libx264
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description (last modified by Carl Eugen Hoyos)

Summary of the bug:
How to reproduce:

When compiling (regardless of having libx264 installed or not)
% ./configure --enable-encoder=libx264
It will not give a "Unknown option" error (I believe it should) and it does not add libx264 to the list of encoders.
I now know the correct way to get libx264 is to use --enable-libx264. But was confused for a while.
here's a the config.log I get
ffmpeg version: N-44711-gf25d53d (that is what I get when I run ./version.sh after downloading the latest source with git)
built on Ubuntu 12.04 and 11.04

Change History (5)

comment:1 by Carl Eugen Hoyos, 10 years ago

Component: undeterminedbuild system
Description: modified (diff)
Keywords: libx264 added
Resolution: invalid
Status: newclosed

The option is not unknown:
Please test "./configure --enable-libx264 --disable-encoders" and "./configure --enable-libx264 --disable-encoders --enable-encoder=libx264"

comment:2 by JunCTionS, 10 years ago

Resolution: invalid
Status: closedreopened

Hmmm I wouldn't set this status to closed yet.

--enable-encoder=libx264 does nothing by itself. it should at least warn the user of that, as some (like myself) may think that it should be enough to enable the encoder (and anything necessary for it to do so).

If you disagree

comment:3 by Carl Eugen Hoyos, 10 years ago

Resolution: invalid
Status: reopenedclosed

comment:4 by Michael Niedermayer, 10 years ago

JunCTionS, if you want configure to print some warning in this case that explains the user that he used the wrong parameter and which is the correct one, such patch would certainly be welcome

in reply to:  4 comment:5 by JunCTionS, 10 years ago

Replying to michael:

JunCTionS, if you want configure to print some warning in this case that explains the user that he used the wrong parameter and which is the correct one, such patch would certainly be welcome

Meh... I'm rather new to programming and don't know where that would go (and I imagine someone familiar with the build system would do it in a flash).
I just thought I'd contribute by suggesting this change which IMO (as a low-level user) is a bug.
I take from this, that it's deemed unnecessary enough not to keep it open (even at low priority) until someone might stumble upon it and implement it.

Note: See TracTickets for help on using tickets.