Opened 11 months ago

Last modified 4 months ago

#11635 new defect

libavutil/pca.[hc] are unused

Reported by: francoisk Owned by:
Priority: normal Component: avutil
Version: git-master Keywords:
Cc: francoisk Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description (last modified by francoisk)

These files were deleted and removed from the makefile in commit cfa68a3381a7f67eed75bc503e75aab076fad3c6 ("Remove unused, never built libavutil/pca.[ch]"). This was somehow undone at some point.

The current state is that libavutil/pca.h is only referenced by libavutil/pca.c and libavutil/pca.c is only referenced from libavutil/tests/pca.c so it's not being built into the library but it is getting tested.

Change History (2)

comment:1 by francoisk, 11 months ago

Description: modified (diff)

comment:2 by Michael Niedermayer, 4 months ago

"This was somehow undone at some point." this is not correct, the change removing it was never included. The commit was merged for the metadata only, so the next merge would be simpler

Note: See TracTickets for help on using tickets.