Changes between Initial Version and Version 1 of Ticket #11194, comment 1


Ignore:
Timestamp:
Sep 16, 2024, 4:59:23 PM (2 years ago)
Author:
Filip

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11194, comment 1

    initial v1  
    11[https://github.com/FFmpeg/FFmpeg/blob/ceb471cfde901d47e705dd32abba1ea8eab269fa/libavformat/utils.c#L283]
    22I think the best solution is to just change the parameter type of "number", currently int, to uint64_t. The function av_get_frame_filename2 is called in many places with an int "number" argument, except for via the frame_pts codepath, where it's a uint64_t "number" argument. It seems safer to me to cast int into uint64_t rather than the other way round, and I don't foresee any side-effects, though I'm inexperienced with C. Shall I try to submit that as a patch?
     3
     4This "number" variable just gets passed through into snprintf, with a negative sign if it's <0.