Opened 2 years ago

Closed 2 years ago

#10943 closed defect (invalid)

"avformat: Enforce one-stream limit where appropriate" breaks audio passthrough in mpv

Reported by: Mitzsch01 Owned by:
Priority: normal Component: avformat
Version: unspecified Keywords: spdif
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

The change by adding .flags_internal to the file "libavformat/spdifenc.c" causes audio passthrough to fail in mpv.
The issue is reported here => ​https://github.com/mpv-player/mpv/issues/13794

The log there says

[ad] In: profile=60 samplerate=48000
[ffmpeg] spdif: spdif muxer does not support any stream of type unknown
[ad] libavformat spdif initialization failed.

and playback is stuck there.

This can be fixed by just deleting the last line in the file "libavformat/spdifenc.c" 

    .flags_internal    = FF_OFMT_FLAG_MAX_ONE_OF_EACH,

​https://github.com/mitzsch/FFmpeg/commit/907f8c7e25cf8d033d9d28c7eb6aeec3b483268f

Change History (2)

comment:1 by mkver, 2 years ago

The fix is for mpv to just set the stream's codec_type to AVMEDIA_TYPE_AUDIO. Which makes sense given that it is trying to bitstream audio.

comment:2 by mkver, 2 years ago

Resolution: → invalid
Status: new → closed
Note: See TracTickets for help on using tickets.