bug with MP3 file processing that occurs in FFmpeg 4.4 but not in 4.1.

[이아름]

Issue Summary:
There is a problem with MP3 file processing that occurs in FFmpeg 4.4 but not in 4.1.

Steps to Reproduce:
It doesn't matter whether it's ffmpeg, ffprobe or ffplay.

In FFmpeg 4.1, the command ./ffprobe.exe -i - < out.mp3 successfully processes an MP3 file.

However, in FFmpeg 4.4, attempting the same operation with the command ./ffprobe.exe -i - < new.mp3 results in failure.

ffprobe started on 2024-02-08 at 08:59:48
Report written to "ffprobe-20240208-085948.log"
Log level: 99
Command line:
ffprobe.exe -v 9 -loglevel 99 -report -i -
ffprobe version n4.4.4-1-ga66ee3abd2 Copyright (c) 2007-2023 the FFmpeg developers
  built with gcc 13.1.0 (Rev5, Built by MSYS2 project)
  configuration:  --disable-static --enable-shared --pkg-config=pkgconf --cc='ccache gcc' --cxx='ccache g++' --ld='ccache g++' --extra-cxxflags=-fpermissive --extra-cflags=-Wno-int-conversion --disable-autodetect --enable-amf --enable-bzlib --enable-cuda --enable-cuvid --enable-d3d11va --enable-dxva2 --enable-iconv --enable-lzma --enable-nvenc --enable-schannel --enable-zlib --enable-sdl2 --enable-ffnvcodec --enable-nvdec --enable-cuda-llvm --enable-gmp --enable-libmp3lame --enable-libopus --enable-libvorbis --enable-libvpx --enable-libdav1d --enable-libaom --disable-debug --enable-libfdk-aac --extra-libs=-liconv --enable-version3
  libavutil      56. 70.100 / 56. 70.100
  libavcodec     58.134.100 / 58.134.100
  libavformat    58. 76.100 / 58. 76.100
  libavdevice    58. 13.100 / 58. 13.100
  libavfilter     7.110.100 /  7.110.100
  libswscale      5.  9.100 /  5.  9.100
  libswresample   3.  9.100 /  3.  9.100
[NULL @ 00000242d9feb480] Opening 'pipe:' for reading
[pipe @ 00000242d9febf00] Setting default whitelist 'crypto,data'
[AVIOContext @ 00000242dbcd0100] Statistics: 119618 bytes read, 0 seeks
pipe:: Invalid data found when processing input

ffprobe started on 2024-02-08 at 09:04:09
Report written to "ffprobe-20240208-090409.log"
Command line:
ffprobe.exe -v 9 -loglevel 99 -report -i -
ffprobe version 4.1 Copyright (c) 2007-2018 the FFmpeg developers
  built with gcc 6.3.0 (GCC) 20170415
  configuration: --arch=x86_64 --target-os=mingw32 --cross-prefix=x86_64-w64-mingw32- --enable-shared --enable-static --enable-ffplay --enable-version3 --enable-nvenc --enable-nvdec --extra-ldflags='-static-libgcc -L/usr/local/cuda/lib64' --enable-cuvid --enable-cuda --enable-d3d11va --enable-ffnvcodec --extra-cflags=-I/usr/local/cuda/include
  libavutil      56. 22.100 / 56. 22.100
  libavcodec     58. 35.100 / 58. 35.100
  libavformat    58. 20.100 / 58. 20.100
  libavdevice    58.  5.100 / 58.  5.100
  libavfilter     7. 40.101 /  7. 40.101
  libswscale      5.  3.100 /  5.  3.100
  libswresample   3.  3.100 /  3.  3.100
[NULL @ 000000000077b300] Opening 'pipe:' for reading
[pipe @ 000000000077bc00] Setting default whitelist 'crypto'
[mp3 @ 000000000077b300] Format mp3 probed with size=2048 and score=51
id3v2 ver:4 flags:00 len:35
[mp3 @ 000000000077b300] invalid concatenated file detected - using bitrate for duration
[mp3 @ 000000000077b300] pad 576 1344
[mp3 @ 000000000077b300] Skipping 0 bytes of junk at 227.
[mp3 @ 000000000077b300] Before avformat_find_stream_info() pos: 227 bytes read:32768 seeks:0 nb_streams:1
[mp3 @ 000000000077b300] demuxer injecting skip 1105 / discard 0
[mp3float @ 000000000077d380] skip 1105 / discard 0 samples due to side data
[mp3float @ 000000000077d380] skip 1105/1152 samples
[mp3 @ 000000000077b300] All info found
[mp3 @ 000000000077b300] After avformat_find_stream_info() pos: 11491 bytes read:32768 seeks:0 frames:50
Input #0, mp3, from 'pipe:':
  Metadata:
    encoder         : Lavf58.76.100
  Duration: N/A, start: 0.025057, bitrate: 64 kb/s
    Stream #0:0, 50, 1/14112000: Audio: mp3, 44100 Hz, mono, fltp, 64 kb/s
[AVIOContext @ 0000000002bc8100] Statistics: 32768 bytes read, 0 seeks

[이아름]

this audio working 4.1 not working 4.4

[이아름]

Using git bisect, I found where the code went wrong!!

When I deleted the changes in that commit, it worked fine in tags/n4.4.4 !!

bug patch plz..

c22665ae691ca313793330bfa7c9a2b70d53cbdf is the first bad commit
commit c22665ae691ca313793330bfa7c9a2b70d53cbdf
Author: Limin Wang <lance.lmwang@gmail.com>
Date:   Fri Nov 8 00:16:22 2019 +0800

    avformat/mp3dec: Check for occurances of headers within frames during probing

    Fixes misdetection of zYLx.wav

    Reviewed-by: Paul B Mahol <onemda@gmail.com>
    Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

:040000 040000 cf7d289d964c1512c73f468300272cd7c2b02fee 6901192ef632823a54f1d2afd05d5fdc7fb04191 M      libavformat
(base)