Opened 6 months ago

Closed 6 months ago

#10745 closed defect (fixed)

heap-buffer-overflow at libavfilter/vf_swaprect.c:191:17 in FFmpeg

Reported by: ZengYunxiang Owned by:
Priority: important Component: avfilter
Version: git-master Keywords: bugs
Cc: ZengYunxiang Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Summary of the bug:

Dear developers,

We found the following heap-buffer-overflow bug on FFmpeg(version N-113007-g8d24a28d06) when using swaprect filter, please confirm.

The poc file(poc12ffmpeg) will be attached to this ticket.

How to reproduce:

git clone https://github.com/FFmpeg/FFmpeg.git ffmpeg
cd ffmpeg
./configure --cc=clang --cxx=clang++ --ld=clang --enable-debug --toolchain=clang-asan
make -j30

./ffmpeg_g -y -i poc12ffmpeg -filter_complex swaprect tmp.mp4

ASAN Log:

=================================================================
==1410562==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7fee82547fe0 at pc 0x55dfa43528b7 bp 0x7feea43ec130 sp 0x7f                            eea43eb900
READ of size 2016 at 0x7fee82547fe0 thread T18 (fc0)
    Last message repeated 1 times
    #0 0x55dfa43528b6 in __asan_memcpy (/ffmpeg/ffmpeg_g+0x9308b6) (BuildId: bab21e45d9666c5cb0f3fbb9efc25079a5bb0a62)
    #1 0x55dfa497cbf0 in filter_frame /ffmpeg/libavfilter/vf_swaprect.c:191:17
    #2 0x55dfa44b1ee2 in ff_filter_frame_framed /ffmpeg/libavfilter/avfilter.c:969:11
    #3 0x55dfa44b1ee2 in ff_filter_frame_to_filter /ffmpeg/libavfilter/avfilter.c:1123:11
    #4 0x55dfa44b1ee2 in ff_filter_activate_default /ffmpeg/libavfilter/avfilter.c:1182:20
    #5 0x55dfa44b1ee2 in ff_filter_activate /ffmpeg/libavfilter/avfilter.c:1341:11
    #6 0x55dfa44c3f67 in push_frame /ffmpeg/libavfilter/buffersrc.c:168:15
    #7 0x55dfa44c3f67 in av_buffersrc_add_frame_flags /ffmpeg/libavfilter/buffersrc.c:272:15
    #8 0x55dfa43ae85b in send_frame /ffmpeg/fftools/ffmpeg_filter.c:2673:11
    #9 0x55dfa43ae85b in filter_thread /ffmpeg/fftools/ffmpeg_filter.c:2813:19
    #10 0x55dfa43f24e8 in task_wrapper /ffmpeg/fftools/ffmpeg_sched.c:2200:21
    #11 0x7feeaef1dac2  (/lib/x86_64-linux-gnu/libc.so.6+0x94ac2) (BuildId: 203de0ae33b53fee1578b117cb4123e85d0534f0)
    #12 0x7feeaefaf65f  (/lib/x86_64-linux-gnu/libc.so.6+0x12665f) (BuildId: 203de0ae33b53fee1578b117cb4123e85d0534f0)

0x7fee82547fe0 is located 1952 bytes to the right of 1912896-byte region [0x7fee82374800,0x7fee82547840)
allocated by thread T18 (fc0) here:
    #0 0x55dfa4354107 in __interceptor_posix_memalign (/ffmpeg/ffmpeg_g+0x932107) (BuildId: bab21e45d9666c5cb0f3fbb9efc25079a5bb0                            a62)
    #1 0x55dfa79d9fbe in av_malloc /ffmpeg/libavutil/mem.c:105:9
    #2 0x55dfa798f0dc in av_buffer_alloc /ffmpeg/libavutil/buffer.c:82:12
    #3 0x55dfa798f0dc in av_buffer_allocz /ffmpeg/libavutil/buffer.c:95:24
    #4 0x55dfa79911b3 in pool_alloc_buffer /ffmpeg/libavutil/buffer.c:363:26
    #5 0x55dfa79911b3 in av_buffer_pool_get /ffmpeg/libavutil/buffer.c:401:15
    #6 0x55dfa44f9e26 in ff_frame_pool_get /ffmpeg/libavfilter/framepool.c:217:29
    #7 0x55dfa4aa03ed in ff_default_get_video_buffer2 /ffmpeg/libavfilter/video.c:94:13
    #8 0x55dfa44b3f86 in ff_inlink_make_frame_writable /ffmpeg/libavfilter/avfilter.c:1449:15
    #9 0x55dfa44b1929 in ff_filter_frame_framed /ffmpeg/libavfilter/avfilter.c:958:15
    #10 0x55dfa44b1929 in ff_filter_frame_to_filter /ffmpeg/libavfilter/avfilter.c:1123:11
    #11 0x55dfa44b1929 in ff_filter_activate_default /ffmpeg/libavfilter/avfilter.c:1182:20
    #12 0x55dfa44b1929 in ff_filter_activate /ffmpeg/libavfilter/avfilter.c:1341:11
    #13 0x55dfa44c3f67 in push_frame /ffmpeg/libavfilter/buffersrc.c:168:15
    #14 0x55dfa44c3f67 in av_buffersrc_add_frame_flags /ffmpeg/libavfilter/buffersrc.c:272:15
    #15 0x55dfa43ae85b in send_frame /ffmpeg/fftools/ffmpeg_filter.c:2673:11
    #16 0x55dfa43ae85b in filter_thread /ffmpeg/fftools/ffmpeg_filter.c:2813:19
    #17 0x55dfa43f24e8 in task_wrapper /ffmpeg/fftools/ffmpeg_sched.c:2200:21
    #18 0x7feeaef1dac2  (/lib/x86_64-linux-gnu/libc.so.6+0x94ac2) (BuildId: 203de0ae33b53fee1578b117cb4123e85d0534f0)

Thread T18 (fc0) created by T0 here:
    #0 0x55dfa433ca0c in __interceptor_pthread_create (/ffmpeg/ffmpeg_g+0x91aa0c) (BuildId: bab21e45d9666c5cb0f3fbb9efc25079a5bb0                            a62)
    #1 0x55dfa43eca31 in task_start /ffmpeg/fftools/ffmpeg_sched.c:403:11
    #2 0x55dfa440b738 in transcode /ffmpeg/fftools/ffmpeg.c:922:11
    #3 0x55dfa440b738 in main /ffmpeg/fftools/ffmpeg.c:1050:11
    #4 0x7feeaeeb2d8f  (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId: 203de0ae33b53fee1578b117cb4123e85d0534f0)

SUMMARY: AddressSanitizer: heap-buffer-overflow (/ffmpeg/ffmpeg_g+0x9308b6) (BuildId: bab21e45d9666c5cb0f3fbb9efc25079a5bb0a62) i                            n __asan_memcpy
Shadow bytes around the buggy address:
  0x0ffe504a0fa0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffe504a0fb0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffe504a0fc0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffe504a0fd0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffe504a0fe0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0ffe504a0ff0: fa fa fa fa fa fa fa fa fa fa fa fa[fa]fa fa fa
  0x0ffe504a1000: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffe504a1010: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffe504a1020: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffe504a1030: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffe504a1040: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==1410562==ABORTING

ffmpeg version:

# ./ffmpeg -version
ffmpeg version N-113007-g8d24a28d06 Copyright (c) 2000-2023 the FFmpeg developers
built with Ubuntu clang version 14.0.0-1ubuntu1.1
configuration: --cc=clang --cxx=clang++ --ld=clang --enable-debug --toolchain=clang-asan
libavutil      58. 34.100 / 58. 34.100
libavcodec     60. 35.100 / 60. 35.100
libavformat    60. 18.100 / 60. 18.100
libavdevice    60.  4.100 / 60.  4.100
libavfilter     9. 14.100 /  9. 14.100
libswscale      7.  6.100 /  7.  6.100
libswresample   4. 13.100 /  4. 13.100

Credit:

Discovered by Li Zeyuan and Zeng Yunxiang.

Thanks for your time!

Attachments (1)

poc12ffmpeg​ (66.5 KB ) - added by ZengYunxiang 6 months ago.
POC file

Download all attachments as: .zip

Change History (2)

by ZengYunxiang, 6 months ago

Attachment: poc12ffmpeg​ added

POC file

comment:1 by Michael Niedermayer, 6 months ago

Resolution: → fixed
Status: new → closed

Fixed by 7deaca71b32c556620e05954ca2d13fbe9aacf1f

Note: See TracTickets for help on using tickets.