Opened 4 years ago

Closed 4 years ago

#1050 closed defect (fixed)

Incomplete pkgconfig file libavdevice.pc

Reported by: marlam Owned by:
Priority: important Component: build system
Version: git-master Keywords: lavfi
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Hi!

The information recorded in libavdevice.pc is sometimes incomplete.

When configured with indev lavfi (libavdevice/lavfi.c), which is the default, then libavdevice requires libavfilter, but that is not recorded in the Requires: or Requires.private: field.

Attachments (2)

patchavdevicepc.diff (1.4 KB) - added by cehoyos 4 years ago.
patchavdevicepc2.diff (1.5 KB) - added by cehoyos 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by cehoyos

Could you send a patch to ffmpeg-devel?

comment:2 Changed 4 years ago by marlam

I tried to make a patch, but I was not able to figure out how the configure magic works.

How do I find out whether libavdevice/lavfi.c is enabled or not?

For libavfilter, there are 'enabled libavfilter_deps_*' tests, but I did not understand how these work.

Changed 4 years ago by cehoyos

comment:3 Changed 4 years ago by cehoyos

  • Priority changed from normal to important
  • Status changed from new to open

Could you test attached patch?

Changed 4 years ago by cehoyos

comment:4 Changed 4 years ago by cehoyos

Improved patch attached.

comment:5 Changed 4 years ago by marlam

It works beautifully here. Thank you very much!

The 'enabled lavfi_indev' test was the thing I could not figure out. Thanks for helping, I really appreciate it.

comment:6 Changed 4 years ago by cehoyos

  • Keywords lavfi added
  • Resolution set to fixed
  • Status changed from open to closed

Patch applied, thank you for testing!

Note: See TracTickets for help on using tickets.