Opened 10 years ago

Closed 10 years ago

#1050 closed defect (fixed)

Incomplete pkgconfig file libavdevice.pc

Reported by: Martin Lambers Owned by:
Priority: important Component: build system
Version: git-master Keywords: lavfi
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Hi!

The information recorded in libavdevice.pc is sometimes incomplete.

When configured with indev lavfi (libavdevice/lavfi.c), which is the default, then libavdevice requires libavfilter, but that is not recorded in the Requires: or Requires.private: field.

Attachments (2)

patchavdevicepc.diff (1.4 KB ) - added by Carl Eugen Hoyos 10 years ago.
patchavdevicepc2.diff (1.5 KB ) - added by Carl Eugen Hoyos 10 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by Carl Eugen Hoyos, 10 years ago

Could you send a patch to ffmpeg-devel?

comment:2 by Martin Lambers, 10 years ago

I tried to make a patch, but I was not able to figure out how the configure magic works.

How do I find out whether libavdevice/lavfi.c is enabled or not?

For libavfilter, there are 'enabled libavfilter_deps_*' tests, but I did not understand how these work.

by Carl Eugen Hoyos, 10 years ago

Attachment: patchavdevicepc.diff added

comment:3 by Carl Eugen Hoyos, 10 years ago

Priority: normalimportant
Status: newopen

Could you test attached patch?

by Carl Eugen Hoyos, 10 years ago

Attachment: patchavdevicepc2.diff added

comment:4 by Carl Eugen Hoyos, 10 years ago

Improved patch attached.

comment:5 by Martin Lambers, 10 years ago

It works beautifully here. Thank you very much!

The 'enabled lavfi_indev' test was the thing I could not figure out. Thanks for helping, I really appreciate it.

comment:6 by Carl Eugen Hoyos, 10 years ago

Keywords: lavfi added
Resolution: fixed
Status: openclosed

Patch applied, thank you for testing!

Note: See TracTickets for help on using tickets.