Opened 6 years ago

Closed 6 years ago

#1030 closed defect (fixed)

Doesn't build with -Werror=format-security

Reported by: marillat Owned by:
Priority: normal Component: avcodec
Version: 0.10 Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Hi,

Debian use hardening compile-time options ​http://wiki.debian.org/Hardening

ffmpeg fail to build with "-Werror=format-security"

libavcodec/srtdec.c: In function ‘srt_to_ass’:
libavcodec/srtdec.c:113:61: error: format not a string literal and no format arguments [-Werror=format-security]
libavcodec/srtdec.c:113:61: error: format not a string literal and no format arguments [-Werror=format-security]
libavcodec/srtdec.c:149:53: error: format not a string literal and no format arguments [-Werror=format-security]
libavcodec/srtdec.c:149:53: error: format not a string literal and no format arguments [-Werror=format-security]

Patch from ​http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=658929#15 fix this bug.

Christian

Change History (4)

comment:1 Changed 6 years ago by cehoyos

Is this not reproducible with current git head?

Please send patches to ffmpeg-devel where they can be discussed.

comment:2 Changed 6 years ago by marillat

The file is the same, so this bug is reproducible with git head.

I'm not subscribed to ffmpeg-devel because I'm not a developer.

comment:3 Changed 6 years ago by michael

patch applied

please close this issue if this fixes it!

Thanks

comment:4 Changed 6 years ago by marillat

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.