Changes between Initial Version and Version 1 of Ticket #10111


Ignore:
Timestamp:
Jun 26, 2023, 4:03:23 PM (3 years ago)
Author:
Steve Browne
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10111 – Description

    initial v1  
    44The problem lies in encode_send_frame_internal because it uses dst->data[0] to determine if avci->buffer_frame is already pointing to something. Since vaapi contexts only store the surface ID in data[3] it will gladly think buffer_frame is unused and overwrite it without actually encoding it or freeing it. I don't know if all contexts should just store something in data[0] or if that check something else like buf[0], but it's very easy for this to cause a memory leak.
    55
    6 The simple workaround for this is to just set data[0] = data[4] for vaapi.
     6The simple workaround for this is to just set data[0] = data[3] for vaapi.
    77
    88How to reproduce: