Opened 13 years ago

Closed 13 years ago

#95 closed enhancement (fixed)

copytb not initialized to it's default value

Reported by: Robert Owned by:
Priority: normal Component: ffmpeg
Version: unspecified Keywords: copytb
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: yes

Description

The copytb option was added back on SVN 26340. The variable copytb that holds the option's value is declared without being initialized. I assume that the default value is supposed to be zero (and that a compiler would initialize it to zero). Still it looks out of place without its default value explicitly set.

Current code:

static float audio_drift_threshold= 0.1;
static int copy_ts= 0;
static int copy_tb;
static int opt_shortest = 0;

I have attached a patch that explicitly initializes this variable to 0 (assumed default).

Attachments (1)

ffmpeg-initialize-copytb.patch (390 bytes ) - added by Robert 13 years ago.

Download all attachments as: .zip

Change History (5)

by Robert, 13 years ago

comment:1 by Michael Niedermayer, 13 years ago

Analyzed by developer: set
Status: newopen
Type: defectenhancement

The =0 is unneeded (C requires the varible to be initialized to 0)
but i dont mind if someone applies this patch for consistency.

comment:2 by Michael Niedermayer, 13 years ago

Owner: Michael Niedermayer removed

comment:3 by Robert, 13 years ago

That's all I was looking for -- just consistency with the rest of the options.

comment:4 by Carl Eugen Hoyos, 13 years ago

Resolution: fixed
Status: openclosed

Patch applied.

Note: See TracTickets for help on using tickets.