Opened 5 years ago
Closed 5 years ago
#8007 closed enhancement (fixed)
bsf_dump_extra repeat tables
| Reported by: | Anton Torp | Owned by: | |
|---|---|---|---|
| Priority: | wish | Component: | avcodec |
| Version: | git-master | Keywords: | bsf_dump_extra |
| Cc: | Blocked By: | ||
| Blocking: | Reproduced by developer: | no | |
| Analyzed by developer: | no |
Description
Summary of the bug: When using the "bsf_dump_extra" some tables are repeated.
How to reproduce:
% ffmpeg -i input.ts -c:v mpeg2_qsv -bsf:v dump_extra out.ts
With this example, the resulting "out.ts" file has an incorrect header in the first I frame. In this frame the PES tables "SEQUENCE HEADER" and "SEQUENCE EXTENSION" are repeated. And that's a clear bug!
The problem is based on this: The MPEG-2 QSV encoder doesn't repeat these tables. So they only appear in the bitstream in the first I frame. Then every new GOP lacks the tables, and as result the bitstream is not suitable for Broadcasting: If you start to play after the first GOP you can't reproduce the stream.
The solution is then to use the bitstream filter "dump_extra". This filter repeats the required tables at every GOP. But..., the current implementation doesn't check for the existence of a table, and always inserts it... even if they already exists.
So, please can you review the code and fix this bug? The idea is to check the existence of a table before inserting it.
Thank you!
Change History (2)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
| Component: | avfilter → avcodec |
|---|---|
| Priority: | normal → wish |
| Resolution: | → fixed |
| Status: | new → closed |
| Type: | defect → enhancement |
Fixed in 3469cfab4adb242fa2116f4858f0768cec400afa.
Please provide the command line you tested together with the complete, uncut console output to make this a valid ticket.