Opened 2 months ago

Last modified 4 days ago

#7214 new license violation

Amazon violates (L)GPL

Reported by: kierank Owned by:
Priority: normal Component: undetermined
Version: unspecified Keywords:
Cc: flamefew Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: no

Description

Amazon distribute a binary of FFmpeg with some kind of FPGA acceleration that is nonfree. No source code provided.

https://github.com/awslabs/aws-fpga-app-notes/tree/master/reInvent17_Developer_Workshop/ffmpeg

Change History (19)

comment:1 Changed 2 months ago by llogan

They (AWSOpen) have been notified about this on Twitter.

https://twitter.com/daemon404/status/996760928036237313

comment:3 Changed 2 months ago by cehoyos

  • Reproduced by developer set
$ md5sum ffmpeg
09725a633a31da86b9cec69676a4f85c  ffmpeg

comment:4 Changed 2 months ago by flamefew

Thank you ffmpeg community for your patience.

We've worked with @ThomasXilinx on GitHub to update this conference tutorial with the build instructions and patch file. The build downloads the official ffmpeg source code from git.ffmpeg.org, and we have noted this in the LICENSE_README file so users know where they can get the source code from. If you would like us to also provide a copy of the source ourselves, please let me know and we can put a copy up on S3 and link to that.

Last edited 2 months ago by flamefew (previous) (diff)

comment:5 Changed 2 months ago by cehoyos

The ffmpeg binaries in the two repositories are different, the provided patch does not allow to build the binary you distribute.

comment:6 Changed 2 months ago by flamefew

Thanks @cehoyos.

We went back to the contributor, fixed some build-script errors, and had multiple people checking that the build scripts successfully reproduces the uploaded binary. We also found that there were two copies of the binary in the repository and removed one:

https://github.com/awslabs/aws-fpga-app-notes/pull/13

comment:7 Changed 2 months ago by cehoyos

The patchfile looks unchanged, so I don't understand how this can be fixed now.

comment:8 Changed 5 weeks ago by cehoyos

  • Cc flamefew added

Ping?
Are you planning to fix this or will you stop distributing binaries based on FFmpeg?

comment:9 Changed 5 weeks ago by flamefew

Apologies for the delay; I've asked the contributing company (Xilinx) to respond.

comment:10 Changed 5 weeks ago by twowings

@cehoyos, you are correct that the patchfile we distributed did not allow to build the same binary. This is because as we uploaded the correct patchfile, we mistakenly uploaded an incorrect binary. This was fixed with https://github.com/awslabs/aws-fpga-app-notes/pull/13, not by uploading a new patchfile, but uploading the correct binary. The current patchfile and build scripts posted on Github will allow you to build the correct binary. This is why we believe the Github content to be now resolving the issue even if the patchfile didn’t change.

comment:11 Changed 5 weeks ago by cehoyos

But where can I find the source to build the original binary?

comment:12 Changed 5 weeks ago by kierank

The ffmpeg binary that is shipped still contains "--enable-nonfree"

comment:13 Changed 3 weeks ago by twowings

@kierank - We have recompiled the binary without “—enable-nonfree” and posted the update: https://github.com/awslabs/aws-fpga-app-notes/pull/15

@cehoyos – Unfortunately we cannot find the exact source for the original binary, so we propose submitting a PR to Amazon to delete the original binary from GitHub? history – will this address your concern?

comment:14 follow-up: Changed 3 weeks ago by cehoyos

Please provide the patch that implements the Xilinx Advanced Video Codec (H.264) Encoder.

comment:15 follow-up: Changed 2 weeks ago by twowings

Hi @cehoyos – I’m afraid we don’t understand your request. The latest binary (posted here: https://github.com/awslabs/aws-fpga-app-notes/blob/master/reInvent17_Developer_Workshop/ffmpeg/ffmpeg) only contains the H.265 encoder. Please review and confirm this is ok. If desired, we can remove the old binary from GitHub? history.

comment:16 in reply to: ↑ 15 Changed 2 weeks ago by cehoyos

Replying to twowings:

Hi @cehoyos – I’m afraid we don’t understand your request. The latest binary (posted here: https://github.com/awslabs/aws-fpga-app-notes/blob/master/reInvent17_Developer_Workshop/ffmpeg/ffmpeg) only contains the H.265 encoder. Please review and confirm this is ok. If desired, we can remove the old binary from GitHub? history.

I believe you would either have to remove all binaries based on FFmpeg source code from github (and any other places where you distribute binaries based on FFmpeg) forever or provide the patch that implements the Xilinx Advanced Video Codec (H.264) Encoder but I am not a lawyer and we have no means to go after copyright violators so if you do neither, we just leave this ticket open.

comment:17 Changed 5 days ago by twowings

Hi @cehoyos, we will provide the patch that implements the Xilinx Advanced Video Codec (H.264) Encoder plug-in. We hope this will address all your remaining concerns.

comment:18 in reply to: ↑ 14 ; follow-up: Changed 4 days ago by heleppkes

Replying to cehoyos:

Please provide the patch that implements the Xilinx Advanced Video Codec (H.264) Encoder.

The patch for that encoder is already available in the repository linked above - https://github.com/awslabs/aws-fpga-app-notes/blob/master/reInvent17_Developer_Workshop/ffmpeg/build/0001-Xilinx-NGcodec-hevc-ffmpeg-plugin.patch

comment:19 in reply to: ↑ 18 Changed 4 days ago by cehoyos

Replying to heleppkes:

Replying to cehoyos:

Please provide the patch that implements the Xilinx Advanced Video Codec (H.264) Encoder.

The patch for that encoder is already available in the repository linked above - https://github.com/awslabs/aws-fpga-app-notes/blob/master/reInvent17_Developer_Workshop/ffmpeg/build/0001-Xilinx-NGcodec-hevc-ffmpeg-plugin.patch

Why do you think so?

Note: See TracTickets for help on using tickets.