Opened 20 months ago

Closed 5 months ago

Last modified 5 months ago

#6750 closed defect (fixed)

ffmpeg-3.4/libavformat/mxfdec.c:2340]: (style) Suspicious condition

Reported by: dcb Owned by:
Priority: normal Component: avformat
Version: git-master Keywords: mxf
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

ffmpeg-3.4/libavformat/mxfdec.c:2340]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

SET_TS_METADATA(pb, "modification_date", ts, str);

but

#define SET_TS_METADATA(pb, name, var, str) do { \

var = avio_rb64(pb); \
if ((ret = avpriv_dict_set_timestamp(&s->metadata, name, mxf_timestamp_to_int64(var)) < 0)) \

return ret; \

} while (0)

maybe better code

#define SET_TS_METADATA(pb, name, var, str) do { \

var = avio_rb64(pb); \
if ((ret = avpriv_dict_set_timestamp(&s->metadata, name, mxf_timestamp_to_int64(var))) < 0) \

return ret; \

} while (0)

Change History (2)

comment:1 Changed 5 months ago by richardpl

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 5 months ago by cehoyos

  • Keywords mxf added
  • Version changed from unspecified to git-master
Note: See TracTickets for help on using tickets.