Opened 5 weeks ago

Last modified 5 weeks ago

#6749 new defect

ffmpeg-3.4/libavcodec/eatqi.c:115: suspicious assignment ?

Reported by: dcb Owned by:
Priority: normal Component: avcodec
Version: unspecified Keywords:
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

ffmpeg-3.4/libavcodec/eatqi.c:115]: (style) int result is assigned to long variable.

Source code is

const int64_t qscale = (215 - 2*quant)*5;

maybe better code

const int64_t qscale = (215L - 2*quant)*5;

Change History (3)

comment:1 Changed 5 weeks ago by jkqxz

What difference would it make? quant is not large.

comment:2 Changed 5 weeks ago by dcb

So would it be a good idea to make qscale into an int ?

comment:3 Changed 5 weeks ago by heleppkes

Its fine the way it is.

Note: See TracTickets for help on using tickets.