Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5997 closed defect (fixed)

Doesn't build with chromaprint 1.4

Reported by: marillat Owned by:
Priority: normal Component: avformat
Version: git-master Keywords: chromaprint
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Build is i386 Debian unstable

CC	libavformat/chromaprint.o
libavformat/chromaprint.c:42:24: error: field ‘ctx’ has incomplete type
     ChromaprintContext ctx;
                        ^~~
libavformat/chromaprint.c: In function ‘write_packet’:
libavformat/chromaprint.c:112:39: warning: passing argument 2 of ‘chromaprint_feed’ from incompatible pointer type [-Wincompatible-pointer-types]
     return chromaprint_feed(cpr->ctx, pkt->data, pkt->size / 2) ? 0 : AVERROR(EINVAL);
                                       ^~~
In file included from libavformat/chromaprint.c:25:0:
/usr/include/chromaprint.h:235:21: note: expected ‘const int16_t * {aka const short int *}’ but argument is of type ‘uint8_t * {aka unsigned char *}’
 CHROMAPRINT_API int chromaprint_feed(ChromaprintContext *ctx, const int16_t *data, int size);
                     ^~~~~~~~~~~~~~~~
libavformat/chromaprint.c: In function ‘write_trailer’:
libavformat/chromaprint.c:127:52: warning: passing argument 2 of ‘chromaprint_get_raw_fingerprint’ from incompatible pointer type [-Wincompatible-pointer-types]
     if (!chromaprint_get_raw_fingerprint(cpr->ctx, &fp, &size)) {
                                                    ^
In file included from libavformat/chromaprint.c:25:0:
/usr/include/chromaprint.h:273:21: note: expected ‘uint32_t ** {aka unsigned int **}’ but argument is of type ‘void **’
 CHROMAPRINT_API int chromaprint_get_raw_fingerprint(ChromaprintContext *ctx, uint32_t **fingerprint, int *size);
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libavformat/chromaprint.c:138:71: warning: passing argument 4 of ‘chromaprint_encode_fingerprint’ from incompatible pointer type [-Wincompatible-pointer-types]
         if (!chromaprint_encode_fingerprint(fp, size, cpr->algorithm, &enc_fp, &enc_size,
                                                                       ^
In file included from libavformat/chromaprint.c:25:0:
/usr/include/chromaprint.h:331:21: note: expected ‘char **’ but argument is of type ‘void **’
 CHROMAPRINT_API int chromaprint_encode_fingerprint(const uint32_t *fp, int size, int algorithm, char **encoded_fp, int *encoded_size, int base64);
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libavformat/chromaprint.c: In function ‘write_packet’:
libavformat/chromaprint.c:113:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
cc1: some warnings being treated as errors

Change History (2)

comment:1 Changed 2 years ago by cehoyos

  • Component changed from undetermined to avformat
  • Keywords chromaprint added
  • Resolution set to fixed
  • Status changed from new to closed

Hopefully fixed by Georgi D. Sotirov in 581f93f37ef2e7a00662828ed0348d1edb9041fe

comment:2 Changed 2 years ago by marillat

Yes, bug fixed.
Thanks

Note: See TracTickets for help on using tickets.