Opened 3 years ago

Closed 3 years ago

#5455 closed enhancement (fixed)

service_type "HEVC digital television service" (0x1F)

Reported by: smallishzulu Owned by:
Priority: wish Component: avformat
Version: git-master Keywords: mpegts
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Hello,

In mpegtsenc.c file under libavformat, there need to add new definition for HEVC service type:

service_type "HEVC digital television service" (0x1F)

ETSI EN 300 468 V 1.13.1
https://www.dvb.org/resources/public/standards/a38_dvb-si_specification.pdf
Page: 185 (end of page)

Fix in mpegtsenc.c:

Line:70 MPEGTS_SERVICE_TYPE_ADVANCED_CODEC_DIGITAL_HDTV = 0x19
};

to

Line:70 MPEGTS_SERVICE_TYPE_ADVANCED_CODEC_DIGITAL_HDTV = 0x19,
Line:71 MPEGTS_SERVICE_TYPE_HEVC_DIGITAL_HDTV = 0x1F
};

And,

Line: 1814 { "advanced_codec_digital_hdtv", "Advanced Codec Digital HDTV.",

0, AV_OPT_TYPE_CONST, { .i64 = MPEGTS_SERVICE_TYPE_ADVANCED_CODEC_DIGITAL_HDTV }, 0x01, 0xff,
AV_OPT_FLAG_ENCODING_PARAM, "mpegts_service_type" },

to

Line: 1814 { "advanced_codec_digital_hdtv", "Advanced Codec Digital HDTV.",

0, AV_OPT_TYPE_CONST, { .i64 = MPEGTS_SERVICE_TYPE_ADVANCED_CODEC_DIGITAL_HDTV }, 0x01, 0xff,
AV_OPT_FLAG_ENCODING_PARAM, "mpegts_service_type" },

Line: 1815 { "hevc_digital_hdtv", "HEVC Digital Television Service.",

0, AV_OPT_TYPE_CONST, { .i64 = MPEGTS_SERVICE_TYPE_HEVC_DIGITAL_HDTV }, 0x01, 0xff,
AV_OPT_FLAG_ENCODING_PARAM, "mpegts_service_type" },

Sorru I couldnt supply diff file, as I don't know how to do.

Regards,

Change History (11)

comment:1 Changed 3 years ago by cehoyos

  • Keywords mpegts added; hevc dvb etsi removed
  • Priority changed from normal to wish

Please send your patch made with git format-patch to the development mailing list, patches are ignored on this bug tracker: Update your source tree, make your changes, test them, commit your changes with git commit libavformat, produce a patch file with git format-patch HEAD^ and send the patch as attachment to the development mailing list.

comment:2 follow-up: Changed 3 years ago by smallishzulu

I wish I couldn know how to do these. I hope someone else does.

comment:3 in reply to: ↑ 2 Changed 3 years ago by cehoyos

Replying to smallishzulu:

I wish I couldn know how to do these.

For which step do you need help?

I hope someone else does.

You already made the patch and you tested it. Why should somebody else repeat this work?

comment:4 follow-up: Changed 3 years ago by smallishzulu

Yes, I did. But how I do it is, I git clone the repo and then modify the code with my favorite editor Vi and than compile it.

So if you can tell me how to make diff file and the mailing list info, I can post them there.

comment:5 in reply to: ↑ 4 Changed 3 years ago by cehoyos

Replying to smallishzulu:

Yes, I did. But how I do it is, I git clone the repo and then modify the code with my favorite editor Vi and than compile it.

This is exactly how I do it.
Please read comment:1 and if any step is unclear, please ask.

comment:6 Changed 3 years ago by smallishzulu

Hi,

I did "git format-patch" and than I did "git commit libavformat" and written commit note.
Now, what to do? git push does not work. How can I get commit and push it on dev mail list ?

comment:7 Changed 3 years ago by cehoyos

After doing git commit, git format-patch HEAD^ produces a file that you can use as attachment for your mail the development mailing list.

comment:8 Changed 3 years ago by smallishzulu

Done:

Your message entitled

Patch for Trac Tickets 5388 & 5455

was successfully received by the ffmpeg-devel mailing list.

Thank you.

comment:9 Changed 3 years ago by cehoyos

Now please split your patch (one patch per ticket) but note that I am not convinced that the mp2 patch is ok.

comment:10 Changed 3 years ago by smallishzulu

OK

comment:11 Changed 3 years ago by cehoyos

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.