Opened 7 years ago

Closed 6 years ago

#1743 closed defect (fixed)

SDL out doesn't respond to clicking the window "x" close

Reported by: rogerdpack Owned by:
Priority: normal Component: avdevice
Version: git-master Keywords: sdl
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: yes

Description

How to reproduce:

% ffmpeg -i vids/sintel.mpg -f sdl "yo"
ffmpeg version N-44224-gde9f5b6 Copyright (c) 2000-2012 the FFmpeg developers
  built on Sep  6 2012 17:59:21 with gcc 4.6 (Ubuntu/Linaro 4.6.3-1ubuntu5)
  configuration: 
  libavutil      51. 72.100 / 51. 72.100
  libavcodec     54. 55.100 / 54. 55.100
  libavformat    54. 25.105 / 54. 25.105
  libavdevice    54.  2.100 / 54.  2.100
  libavfilter     3. 15.104 /  3. 15.104
  libswscale      2.  1.101 /  2.  1.101
  libswresample   0. 15.100 /  0. 15.100
[mpeg2video @ 0x9cbe8a0] ac-tex damaged at 40 7
[mpeg2video @ 0x9cbe8a0] Warning MVs not available
[mpeg2video @ 0x9cbe8a0] concealing 1035 DC, 1035 AC, 1035 MV errors in I frame
[mpeg @ 0x9cb8500] max_analyze_duration 5000000 reached at 5024000
Input #0, mpeg, from 'vids/sintel.mpg':
  Duration: 00:14:47.58, start: 0.233367, bitrate: 4132 kb/s
    Stream #0:0[0x1e0]: Video: mpeg2video (Main), yuv420p, 720x480 [SAR 32:27 DAR 16:9], 7000 kb/s, 29.97 fps, 29.97 tbr, 90k tbn, 59.94 tbc
    Stream #0:1[0x80]: Audio: ac3, 48000 Hz, 5.1(side), s16, 448 kb/s
[sdl @ 0x9cbec60] w:720 h:480 fmt:yuv420p sar:32/27 -> w:720 h:405
Output #0, sdl, to 'yo':
  Metadata:
    encoder         : Lavf54.25.105
    Stream #0:0: Video: rawvideo (I420 / 0x30323449), yuv420p, 720x480 [SAR 32:27 DAR 16:9], q=2-31, 200 kb/s, 90k tbn, 29.97 tbc
Stream mapping:
  Stream #0:0 -> #0:0 (mpeg2video -> rawvideo)
Press [q] to stop, [?] for help

It plays all right.

If you click the window's "x" button, it doesn't do anything, which is a bit inconvenient at times.
Thanks!

Change History (4)

comment:1 Changed 7 years ago by cehoyos

  • Reproduced by developer set
  • Status changed from new to open
  • Type changed from enhancement to defect
  • Version changed from unspecified to git-master

comment:2 Changed 6 years ago by richardpl

  • Component changed from undetermined to avdevice

This is libavdevice limitation.

comment:3 Changed 6 years ago by rogerdpack

on windows it also doesn't allow resizing or dragging of the window. On both Linux and Windows, the "X" command seemingly does nothing. Not sure if it's related.

comment:4 Changed 6 years ago by saste

  • Analyzed by developer set
  • Resolution set to fixed
  • Status changed from open to closed

Should be fixed in:

commit 7de3b1394b71118279e8f997be490633bc3f5d46
Author: Stefano Sabatini <stefasab@gmail.com>
Date:   Sun Nov 24 19:32:59 2013 +0100

    lavd/sdl: add event handler thread
    
    SDL_Init() is called on the event handler thread, as required by SDL in
    Windows to avoid deadlocks as discovered by Roger Pack.
    
    Fix trac ticket #1743 and #1744.

Resize issue addressed in a further patch. Dragging worked last time I tested on Windows, feel free to open a separate ticket if it doesn't.

Note: See TracTickets for help on using tickets.